Merge lp:~gary/juju-gui/restanalytics into lp:juju-gui/experimental

Proposed by Gary Poster on 2013-06-14
Status: Merged
Approved by: Diogo Matsubara on 2013-07-10
Approved revision: 733
Merged at revision: 810
Proposed branch: lp:~gary/juju-gui/restanalytics
Merge into: lp:juju-gui/experimental
Diff against target: 89 lines (+16/-19)
1 file modified
docs/analytics.rst (+16/-19)
To merge this branch: bzr merge lp:~gary/juju-gui/restanalytics
Reviewer Review Type Date Requested Status
Diogo Matsubara (community) 2013-06-14 Approve on 2013-06-14
Review via email: mp+169407@code.launchpad.net

Commit message

tweak analytics ReST

Description of the change

To post a comment you must log in.
Gary Poster (gary) wrote :
Download full text (3.7 KiB)

Reviewers: mp+169407_code.launchpad.net,

Message:
Please take a look.

Description:
tweak analytics ReST

https://code.launchpad.net/~gary/juju-gui/restanalytics/+merge/169407

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/10249047/

Affected files:
   A [revision details]
   M docs/analytics.rst

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: docs/analytics.rst
=== modified file 'docs/analytics.rst'
--- docs/analytics.rst 2013-06-10 18:58:49 +0000
+++ docs/analytics.rst 2013-06-14 12:40:01 +0000
@@ -1,5 +1,5 @@
  =========
-ANALYTICS
+Analytics
  =========

  In order to gauge exactly how the Juju GUI is being utilized, we are
gathering
@@ -26,13 +26,12 @@
  Events / Overview". The lag makes instrumenting the code slow and a bit
  frustrating.

-
  Unified reporting
  =================

  Our use of Google Analytics is a bit non-standard. GA is intended to
gather
  statistics for a single site or cooperating group of sites. They term the
-latter "cross-domain tracking"[1] and its intended use is to provide the
+latter "cross-domain tracking" [1]_ and its intended use is to provide the
  ability to get a single set of statics for cooperating but disparate web
  resources such as example.com, blog.example.com, and
  example.shoppingcart.com.
@@ -106,7 +105,6 @@
  Once Juju GUI is deployed a user can change that config setting to turn off
  analytics.

-
  Custom events
  =============

@@ -134,7 +132,7 @@
  of new processing we do to support the instrumentation so as to not affect
the
  performance of the actual app.

-The calls to _trackEvent[2] look like:
+The calls to _trackEvent [2]_ look like:

  _trackEvent(category, action, opt_label, opt_value, opt_noninteraction)

@@ -150,33 +148,32 @@
  to one of those specifiers. The best way to do that remains an open
  question.

-=========
+A-B Testing
+===========
+
+GA can be used for A-B testing [3]_.
+
  Questions
  =========

  Anonymizing
-===========
+-----------

-Should we take advantage of the anonymizeIp feature? Using it will report
0
+Should we take advantage of the anonymizeIp feature [4]_? Using it will
report 0
  for the last octet of an IPv4 address. The city-level accuracy of
geography
  reporting will be affected but country data should still be accurate.

  Site identification
-===================
+-------------------

  If we want to identify statistics for a particular site, what is the best
way
  to do that? We need an address or name for the location where Juju GUI is
  deployed, not the address of the client.

-=====
-Other
-=====
-
-GA can be used for A-B testing as described in this post[4].
-
  References
  ==========
-[1]
https://developers.google.com/analytics/devguides/collection/gajs/gaTrackingSite
-[2]
https://developers.google.com/analytics/devguides/collection/gajs/eventTrackerGuide
-[3]
https://d...

Read more...

Gary Poster (gary) wrote :

trivial LGTM. Self reviewing. Something for Diogo to work with in
tarmac tests.

https://codereview.appspot.com/10249047/

review: Approve
Jujugui Lander (jujugui-lander) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/jujugui-merger-trunk/11/console reported an error when processing this lp:~gary/juju-gui/restanalytics branch.
Not merging it.

Jujugui Lander (jujugui-lander) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/jujugui-merger-trunk/13/console reported an error when processing this lp:~gary/juju-gui/restanalytics branch.
Not merging it.

Jujugui Lander (jujugui-lander) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/jujugui-merger-trunk/18/console reported an error when processing this lp:~gary/juju-gui/restanalytics branch.
Not merging it.

Jujugui Lander (jujugui-lander) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/jujugui-merger-trunk/19/console reported an error when processing this lp:~gary/juju-gui/restanalytics branch.
Not merging it.

Jujugui Lander (jujugui-lander) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/jujugui-merger-trunk/20/console reported an error when processing this lp:~gary/juju-gui/restanalytics branch.
Not merging it.

Jujugui Lander (jujugui-lander) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/jujugui-merger-trunk/21/console reported an error when processing this lp:~gary/juju-gui/restanalytics branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'docs/analytics.rst'
2--- docs/analytics.rst 2013-06-10 18:58:49 +0000
3+++ docs/analytics.rst 2013-06-14 12:43:30 +0000
4@@ -1,5 +1,5 @@
5 =========
6-ANALYTICS
7+Analytics
8 =========
9
10 In order to gauge exactly how the Juju GUI is being utilized, we are gathering
11@@ -26,13 +26,12 @@
12 Events / Overview". The lag makes instrumenting the code slow and a bit
13 frustrating.
14
15-
16 Unified reporting
17 =================
18
19 Our use of Google Analytics is a bit non-standard. GA is intended to gather
20 statistics for a single site or cooperating group of sites. They term the
21-latter "cross-domain tracking"[1] and its intended use is to provide the
22+latter "cross-domain tracking" [1]_ and its intended use is to provide the
23 ability to get a single set of statics for cooperating but disparate web
24 resources such as example.com, blog.example.com, and
25 example.shoppingcart.com.
26@@ -106,7 +105,6 @@
27 Once Juju GUI is deployed a user can change that config setting to turn off
28 analytics.
29
30-
31 Custom events
32 =============
33
34@@ -134,7 +132,7 @@
35 of new processing we do to support the instrumentation so as to not affect the
36 performance of the actual app.
37
38-The calls to _trackEvent[2] look like:
39+The calls to _trackEvent [2]_ look like:
40
41 _trackEvent(category, action, opt_label, opt_value, opt_noninteraction)
42
43@@ -150,33 +148,32 @@
44 to one of those specifiers. The best way to do that remains an open
45 question.
46
47-=========
48+A-B Testing
49+===========
50+
51+GA can be used for A-B testing [3]_.
52+
53 Questions
54 =========
55
56 Anonymizing
57-===========
58+-----------
59
60-Should we take advantage of the anonymizeIp feature? Using it will report 0
61+Should we take advantage of the anonymizeIp feature [4]_? Using it will report 0
62 for the last octet of an IPv4 address. The city-level accuracy of geography
63 reporting will be affected but country data should still be accurate.
64
65 Site identification
66-===================
67+-------------------
68
69 If we want to identify statistics for a particular site, what is the best way
70 to do that? We need an address or name for the location where Juju GUI is
71 deployed, not the address of the client.
72
73-=====
74-Other
75-=====
76-
77-GA can be used for A-B testing as described in this post[4].
78-
79 References
80 ==========
81-[1] https://developers.google.com/analytics/devguides/collection/gajs/gaTrackingSite
82-[2] https://developers.google.com/analytics/devguides/collection/gajs/eventTrackerGuide
83-[3] https://developers.google.com/analytics/devguides/collection/gajs/methods/gaJSApi_gat#_gat._anonymizeIp
84-[4] http://analytics.blogspot.com/2013/01/multi-armed-bandit-experiments.html
85+
86+.. [1] https://developers.google.com/analytics/devguides/collection/gajs/gaTrackingSite
87+.. [2] https://developers.google.com/analytics/devguides/collection/gajs/eventTrackerGuide
88+.. [3] http://analytics.blogspot.com/2013/01/multi-armed-bandit-experiments.html
89+.. [4] https://developers.google.com/analytics/devguides/collection/gajs/methods/gaJSApi_gat#_gat._anonymizeIp

Subscribers

People subscribed via source and target branches