lp:~gary/juju-gui/ghostDeploy

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 1050

Juju GUI Hackers: Pending requested 2013-09-16

Diff: 167 lines (+42/-15)

6 files modified

app/store/env/sandbox.js (+11/-3)
app/templates/service-constraints-viewlet.handlebars (+1/-1)
app/templates/service-relations-viewlet.handlebars (+1/-0)
app/views/ghost-inspector.js (+5/-0)
app/views/topology/service.js (+20/-5)
app/views/viewlets/inspector-header.js (+4/-6)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1050. By Gary Poster on 2013-09-16

add some comments

1049. By Gary Poster on 2013-09-16

add some comments

1048. By Gary Poster on 2013-09-16

sketch

1047. By Jeff Pihach on 2013-09-16

Remove ghost CSS duplication

Much of the CSS required for the inspector layout was duplicated for the ghost
inspector, even though the presentation is the same.

The result of this branch should be that the ghost inspector looks exactly the
same, but now with less code and less duplication and fragmentation for future
updates.

(Jeff - Landing for Huw with small fix)
Original: https://codereview.appspot.com/13715044

R=
CC=
https://codereview.appspot.com/13571046

1046. By Richard Harding on 2013-09-16

Add Go support for removing units from services.

- This was missed during the transition to the go backend
- Add the Go handler method to removing a unit.
- Add a test and a note that the equiv. python test is located in another
file.

R=gary.poster
CC=
https://codereview.appspot.com/13349047

1045. By Benji York on 2013-09-16

Factor out charmworld API helpers and rename

These changes are part of the move to adding v3 of the charmworld API.

R=bac, rharding
CC=
https://codereview.appspot.com/13592047

1044. By Gary Poster on 2013-09-16

Add message if no relations exist

R=
CC=
https://codereview.appspot.com/13253054

1043. By Gary Poster on 2013-09-13

Trivial spelling fix

R=
CC=
https://codereview.appspot.com/13250048

1042. By Gary Poster on 2013-09-13

Hook up cancel buttons in the inspector

This branch simply hooks up the cancel buttons, which thanks to groundwork from Ben that I worked on in previous branches, is a one liner for each button.

R=benjamin.saller
CC=
https://codereview.appspot.com/13677044

1041. By Richard Harding on 2013-09-13

Updated how unitName is sent to resolve/retry

The inspector was create an array[array] and thus passing the resovled()
method an array as a unitName. The go back end expects a string and it
refused to resolve/retry anything.

- Update the inspector method to make sure it grabs a single string
- Update the tests for the inspector to look for a single string
- Add a quick assertion in the go backend to fuss if it doesn't get a string

QA:

Note: MySQL always fails for me in my local lxc go environment

- Bootstrap a go environment in lxc, deploy mysql into it. I setup 3 units.
- Wait for the units to go into error state.
- Pick one of the units, resolve the unit.
- After a bit it should go to running and you can destroy it properly.
- Note that you can also watch the WS traffic in chrome dev tools and verify
that your request/response was successful.

Example broken communication:

{"RequestId":31,"Error":"json: cannot unmarshal array into Go value of type string","Response":{}}
{"Type":"Client","Request":"Resolved","Params":{"UnitName":["mysql/0"],"Retry":false},"RequestId":32}

R=benji
CC=
https://codereview.appspot.com/13706043