lp:~gary/juju-gui/fixSandboxDeployRace
- Get this branch:
- bzr branch lp:~gary/juju-gui/fixSandboxDeployRace
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 118 lines (+38/-29)2 files modifiedapp/store/env/fakebackend.js (+21/-29)
test/test_fakebackend.js (+17/-0)
Branch information
Recent revisions
- 1190. By Jeff Pihach
-
Remove remaining old unused notifications code.
R=gary.poster
CC=
https://codereview. appspot. com/23240043 - 1187. By Jeff Pihach
-
Adds support for bundle import button
R=rharding
CC=
https://codereview. appspot. com/22850043 - 1186. By Gary Poster
-
Fix ghost inspector initial name validation
QA: deploy mediawiki with the default name. Make another ghost, and the inspector should correctly show that the default name is invalid.
R=jeff.pihach
CC=
https://codereview. appspot. com/22500043 - 1185. By Gary Poster
-
Adjust 0.11.0 change log
Also document an approach to generating the change log.
R=jeff.pihach
CC=
https://codereview. appspot. com/14990046 - 1184. By Jeff Pihach
-
Switch to new sourcemap syntax
The //@ syntax for source maps now causes IE10 to throw
an error. This branch switches to the new //# syntax which
works as expected across Chrome/FF/IE10.R=matthew.scott
CC=
https://codereview. appspot. com/22450044 - 1183. By Jeff Pihach
-
Fixes upgrade charm page reload in IE10
When clicking a link in the inspector in the upgrade charm
section in IE10 the page would reload instead of dispatching
to the router. This fixes it by generating complete relative
links so that the faulty method in YUI's pjax.base class can
parse them and react accordingly.R=rharding, matthew.scott
CC=
https://codereview. appspot. com/21430043 - 1182. By Gary Poster
-
Improve browser description formatting
I saw antdillon's branch to improve the formatting and really liked the idea (https:/
/code.launchpad .net/~ya- bo-ng/juju- gui/linkify- charm-descripti ons/+merge/ 192852). However, I wanted to improve the testing and the XSS behavior. Trying to accomplish the second of those involved quite a bit of changes from his original design, but there's still a regex in there or two. To QA, look at the mediawiki summary tab. Note that the change log and description now are better formmatted, and have links, and break only for long stuff. mongodb's description shows the pre-line formatting off, and liferay's description shows why truncating at 300 characters was problematic--a url might be cut in half. I thought of some approaches to try and make that work, but I thought that removing the 300 character limit looked better anyway. cassandra's change log is another one to look at: the pre-line works well, I think, and there are a few links to look at in the "earlier changes" section when you expand the change log.
R=huwshimi, rharding
CC=
https://codereview. appspot. com/22200045
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:juju-gui/experimental