Merge lp:~gary/html5-browser/incremental-timeouts into lp:html5-browser
Proposed by
Gary Poster
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||
Approved revision: | 28 | ||||
Merged at revision: | 27 | ||||
Proposed branch: | lp:~gary/html5-browser/incremental-timeouts | ||||
Merge into: | lp:html5-browser | ||||
Diff against target: |
332 lines (+176/-20) 3 files modified
html5browser/__init__.py (+81/-18) html5browser/tests/test_browser.py (+94/-1) setup.py (+1/-1) |
||||
To merge this branch: | bzr merge lp:~gary/html5-browser/incremental-timeouts | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey | code | Approve | |
Review via email: mp+79470@code.launchpad.net |
Description of the change
This adds incremental timeouts, per the discussion we had. My intent is that, for us, the Javascript will report the incremental results when the test suite starts, and after every test pass or fail (the YUI test runner does not provide events when a test suite starts). I have not tried this actually with LP yet, but it looks like this is what we need on the html5-browser side.
pocketlint appears to be happy (I tried ``pocketlint .`` and then ``pocketlint html5browser/
Thanks, Curtis
Gary
To post a comment you must log in.
Wow! This is great. Thank you very much for solving this problem. Can you move the statement to clear the incremental timeout (line 107) to the top of the block (line 105) because I am paranoid that a timeout can happen when the code has determined all is okay.
I'll merge this and make a release when I get your reply.