Merge lp:~gary/charms/precise/juju-gui/markdown into lp:~juju-gui/charms/precise/juju-gui/trunk

Proposed by Gary Poster
Status: Merged
Merged at revision: 15
Proposed branch: lp:~gary/charms/precise/juju-gui/markdown
Merge into: lp:~juju-gui/charms/precise/juju-gui/trunk
Diff against target: 261 lines (+54/-80)
2 files modified
HACKING.txt (+19/-33)
README.txt (+35/-47)
To merge this branch: bzr merge lp:~gary/charms/precise/juju-gui/markdown
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+140279@code.launchpad.net

Description of the change

Move markdown files to .md extension

The charm store needs the document file names to end with .md in order to process them as markdown.

https://codereview.appspot.com/6939067/

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+140279_code.launchpad.net,

Message:
Please take a look.

Description:
Convert docs from ReST to Markdown

We discovered today that ReST is not actully supported by the charm
store, and is not intended to be supported by the charm store or the GUI
any time soon. Convert the docs to Markdown, so they render nicely.

https://code.launchpad.net/~gary/charms/precise/juju-gui/markdown/+merge/140279

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6939067/

Affected files:
   M HACKING.txt
   M README.txt
   A [revision details]

Revision history for this message
Gary Poster (gary) wrote :

self-reviewing doc changes.

As a note, I used retext to generate and test the Markdown. Works
nicely, with live update.http://sourceforge.net/p/retext/home/ReText/

https://codereview.appspot.com/6939067/

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Convert docs from ReST to Markdown

We discovered today that ReST is not actully supported by the charm
store, and is not intended to be supported by the charm store or the GUI
any time soon. Convert the docs to Markdown, so they render nicely.

R=
CC=
https://codereview.appspot.com/6939067

https://codereview.appspot.com/6939067/

Revision history for this message
Gary Poster (gary) wrote :
Revision history for this message
Gary Poster (gary) wrote :

self-reviewing change to .md file extension, per charm store

https://codereview.appspot.com/6939067/

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Move markdown files to .md extension

The charm store needs the document file names to end with .md in order
to process them as markdown.

R=
CC=
https://codereview.appspot.com/6939067

https://codereview.appspot.com/6939067/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'HACKING.txt'
2--- HACKING.txt 2012-12-14 18:04:18 +0000
3+++ HACKING.txt 2012-12-17 19:53:28 +0000
4@@ -1,34 +1,26 @@
5-==========================
6-Juju GUI Charm Development
7-==========================
8+# Juju GUI Charm Development #
9
10-Contacting the Developers
11-=========================
12+## Contacting the Developers ##
13
14 Hi. Thanks for looking at the charm. If you are interested in helping us
15 develop, we'd love to hear from you. Our developer-oriented discussions
16 happen on freenode's IRC network in the #juju-gui channel, and you can also
17-join `the GUI developers mailing list
18-<https://lists.ubuntu.com/mailman/listinfo/juju-gui>`_.
19-
20-
21-Getting Started
22-===============
23+join [the GUI developers mailing list](https://lists.ubuntu.com/mailman/listinfo/juju-gui).
24+
25+
26+## Getting Started ##
27
28 First, you need a configured Juju environment: see the Juju docs about
29-`getting started <https://juju.ubuntu.com/docs/getting-started.html>`_. If you
30+[getting started](https://juju.ubuntu.com/docs/getting-started.html). If you
31 do not yet have an environment defined, the Jitsu command "setup-environment"
32 is an easy way to get started.
33
34 You'll also need some dependencies and developer basics.
35
36-::
37-
38- sudo apt-get install bzr autoconf libtool python-charmhelpers
39+ sudo apt-get install bzr autoconf libtool python-charmhelpers
40
41 Next, you need the bzr branch. We work from
42-`lp:~juju-gui/charms/precise/juju-gui/trunk
43-<https://code.launchpad.net/~juju-gui/charms/precise/juju-gui/trunk>`_.
44+[lp:~juju-gui/charms/precise/juju-gui/trunk](https://code.launchpad.net/~juju-gui/charms/precise/juju-gui/trunk).
45
46 You could start hacking now, but there's a bit more to do to prepare for
47 running and writing tests.
48@@ -36,7 +28,7 @@
49 We use the Jitsu test command to run our functional tests. At the time of
50 this writing it is not yet released. To run it you must first install it
51 locally. The files may be installed globally, or into your home directory (as
52-here)::
53+here):
54
55 sudo apt-get install autoconf libtool python-charmhelpers
56 bzr branch lp:~jimbaker/juju-jitsu/unit-test jitsu-unit-test
57@@ -48,25 +40,23 @@
58
59 The current incarnation of the Jitsu test command requires that the current
60 directory name match the charm name, so you must check out the charm into a
61-directory named "juju-gui"::
62+directory named "juju-gui":
63
64 bzr branch lp:~juju-gui/charms/precise/juju-gui/trunk juju-gui
65
66 The branch directory must be placed (or linked from) within a local charm
67 repository. It consists of a directory, itself containing a number of
68-directories, one for each distribution codename, e.g. ``precise``. In turn, the
69+directories, one for each distribution codename, e.g. `precise`. In turn, the
70 codename directories will contain the charm repositories.
71
72 Now you are ready to run the functional tests (see the next section).
73
74-Testing
75-=======
76+## Testing ##
77
78 There are two types of tests for the charm: unit tests and functional tests.
79
80
81-Unit Tests
82-----------
83+### Unit Tests ###
84
85 The unit tests do not require a functional Juju environment, and can be run
86 with this command::
87@@ -77,11 +67,10 @@
88 customary way (i.e., "test_*.py").
89
90
91-Functional Tests
92-----------------
93+### Functional Tests ###
94
95 Running the functional tests requires a Juju testing environment as provided
96-by the Jitsu test command (see `Getting Started`_, above). All files in the
97+by the Jitsu test command (see "Getting Started", above). All files in the
98 tests directory which end with ".test" will be run in a Juju Jitsu test
99 environment.
100
101@@ -92,10 +81,9 @@
102 --logdir /tmp --timeout 40m
103
104 This command will bootstrap the default Juju environment specified in your
105-``~/.juju/environments.yaml``.
106+`~/.juju/environments.yaml`.
107
108-LXC
109-~~~
110+#### LXC ####
111
112 Unfortunately, we have not found LXC-based Juju environments to be reliable
113 for these tests. At this time, we recommend using other environments, such as
114@@ -105,12 +93,10 @@
115
116 Currently running tests on a local environment is quite slow (with quantal
117 host and precise container at least), so you may want to further increase the
118-``jitsu test`` command timeout.
119+`jitsu test` command timeout.
120
121 If Jitsu generates errors about not being able to bootstrap...
122
123-::
124-
125 CalledProcessError: Command '['juju', 'bootstrap']'...
126
127 ...or if it hangs, then you may need to bootstrap the environment yourself and
128
129=== modified file 'README.txt'
130--- README.txt 2012-12-14 18:04:18 +0000
131+++ README.txt 2012-12-17 19:53:28 +0000
132@@ -1,12 +1,9 @@
133-==============
134-Juju GUI Charm
135-==============
136+# Juju GUI Charm #
137
138 This charm makes it easy to deploy a Juju GUI into an existing environment.
139
140
141-Warning
142-=======
143+## Warning ##
144
145 The GUI and charm have two important limitations that we are actively working
146 on. We plan to publicly announce this charm once these limitations are
147@@ -23,51 +20,46 @@
148 this.
149
150
151-Deploying the Juju GUI
152-======================
153+## Deploying the Juju GUI ##
154
155 Deploying the Juju GUI is accomplished using Juju itself.
156
157 You need a configured and bootstrapped Juju environment: see the Juju docs
158-about `getting started <https://juju.ubuntu.com/docs/getting-started.html>`_,
159+about [getting started](https://juju.ubuntu.com/docs/getting-started.html),
160 and then run the usual bootstrap command.
161
162-::
163-
164- $ juju bootstrap
165-
166-Next, you simply need to deploy the charm and expose it. (See also `Deploying
167-with Jitsu`_ below, for another option.)
168-
169-::
170-
171- $ juju deploy cs:~juju-gui/precise/juju-gui
172- $ juju expose juju-gui
173+ $ juju bootstrap
174+
175+Next, you simply need to deploy the charm and expose it. (See also "Deploying
176+with Jitsu" below, for another option.)
177+
178+ $ juju deploy cs:~juju-gui/precise/juju-gui
179+ $ juju expose juju-gui
180
181 Finally, you need to identify the GUI's URL--sadly, the most annoying part of
182 the process at the moment. Right now (see the warning section above about not
183 yet working with GUI releases) it can take an excessive amount of time for the
184 GUI to be built and to start--20 minutes or more. This command will let you
185-see when it is ready to go by giving you regular status updates::
186+see when it is ready to go by giving you regular status updates:
187
188- $ watch juju status
189+ $ watch juju status
190
191 Eventually, after many minutes, at the end of the status you will hopefully see
192-something that looks like this::
193+something that looks like this:
194
195- services:
196- juju-gui:
197- charm: cs:~juju-gui/precise/juju-gui-7
198- exposed: true
199- relations: {}
200- units:
201- juju-gui/0:
202- agent-state: started
203- machine: 1
204- open-ports:
205- - 80/tcp
206- - 8080/tcp
207- public-address: ec2-204-236-250-8.compute-1.amazonaws.com
208+ services:
209+ juju-gui:
210+ charm: cs:~juju-gui/precise/juju-gui-7
211+ exposed: true
212+ relations: {}
213+ units:
214+ juju-gui/0:
215+ agent-state: started
216+ machine: 1
217+ open-ports:
218+ - 80/tcp
219+ - 8080/tcp
220+ public-address: ec2-204-236-250-8.compute-1.amazonaws.com
221
222 That tells me I can go to the public-address in my browser
223 (http://ec2-204-236-250-8.compute-1.amazonaws.com/ in this example), and start
224@@ -79,8 +71,7 @@
225 be prepared for unpleasant surprises like this.
226
227
228-Deploying with Jitsu
229---------------------
230+### Deploying with Jitsu ###
231
232 The instructions above cause you to use a separate machine to work with the
233 GUI. If you'd like to reduce your machine footprint (and perhaps your costs),
234@@ -90,20 +81,17 @@
235
236 For now, though, install Jitsu...
237
238-::
239-
240- $ sudo apt-get install juju-jitsu
241+ $ sudo apt-get install juju-jitsu
242
243 ...and then replace "juju deploy cs:~juju-gui/precise/juju-gui" from the
244-previous instructions with this::
245-
246- $ jitsu deploy-to 0 cs:~juju-gui/precise/juju-gui
247-
248-Contacting the Developers
249-=========================
250+previous instructions with this:
251+
252+ $ jitsu deploy-to 0 cs:~juju-gui/precise/juju-gui
253+
254+## Contacting the Developers ##
255
256 If you run into problems with the charm, please feel free to contact us on the
257-`Juju mailing list <https://lists.ubuntu.com/mailman/listinfo/juju>`_, or on
258+[Juju mailing list](https://lists.ubuntu.com/mailman/listinfo/juju), or on
259 freenode's IRC network on #juju. We're not always around (working hours in
260 Europe and NA are your best bets), but if you send us a mail or ping "jujugui"
261 we will eventually get back to you.

Subscribers

People subscribed via source and target branches

to all changes: