Ubuntu Weather App

Code review comment for lp:~gary-wzl77/ubuntu-weather-app/snap_fix_1552100

  1. snap_fix_1552100
  2. Merge into reboot
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Awesome! This looks like a good start, there is one inline comment about the plugs. But I think the main thing missing is there is no setup/gui folder with an icon and .desktop file (see the packaging icon and desktop file docs here http://snapcraft.io/docs/build-snaps/metadata#package-icon). You should also be able to modify the icon and .desktop file from the existing click ones.

review: Needs Fixing

« Back to merge proposal