Merge lp:~gary-wzl77/ubuntu-weather-app/snap_fix_1552100 into lp:ubuntu-weather-app

Proposed by Gary.Wang on 2016-11-24
Status: Merged
Approved by: Andrew Hayzen on 2016-12-17
Approved revision: 225
Merged at revision: 252
Proposed branch: lp:~gary-wzl77/ubuntu-weather-app/snap_fix_1552100
Merge into: lp:ubuntu-weather-app
Prerequisite: lp:~gary-wzl77/ubuntu-weather-app/fix_1518888
Diff against target: 209 lines (+194/-0)
2 files modified
setup/gui/ubuntu-weather-app.desktop (+161/-0)
snapcraft.yaml (+33/-0)
To merge this branch: bzr merge lp:~gary-wzl77/ubuntu-weather-app/snap_fix_1552100
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve on 2016-12-17
Andrew Hayzen 2016-11-24 Approve on 2016-11-24
Review via email: mp+311681@code.launchpad.net

Commit message

create snap package by using ubuntu-app-platform plugin.

Description of the change

create snap package by using ubuntu-app-platform plugin.

To post a comment you must log in.
Andrew Hayzen (ahayzen) wrote :

Awesome! This looks like a good start, there is one inline comment about the plugs. But I think the main thing missing is there is no setup/gui folder with an icon and .desktop file (see the packaging icon and desktop file docs here http://snapcraft.io/docs/build-snaps/metadata#package-icon). You should also be able to modify the icon and .desktop file from the existing click ones.

review: Needs Fixing
224. By Gary.Wang on 2016-11-24

add icon and desktop file per andrew's comments.

225. By Gary.Wang on 2016-11-24

update desktop file for i18n.

Andrew Hayzen (ahayzen) wrote :

LGTM, thanks for doing this! As discussed we'll investigate the confinement in a follow up branch.

review: Approve
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'setup'
2=== added directory 'setup/gui'
3=== added file 'setup/gui/icon.png'
4Binary files setup/gui/icon.png 1970-01-01 00:00:00 +0000 and setup/gui/icon.png 2016-11-24 11:01:07 +0000 differ
5=== added file 'setup/gui/ubuntu-weather-app.desktop'
6--- setup/gui/ubuntu-weather-app.desktop 1970-01-01 00:00:00 +0000
7+++ setup/gui/ubuntu-weather-app.desktop 2016-11-24 11:01:07 +0000
8@@ -0,0 +1,161 @@
9+[Desktop Entry]
10+Version=1.0
11+Type=Application
12+Terminal=false
13+Exec=ubuntu-weather-app %u
14+Icon=/snap/ubuntu-weather-app/current/meta/gui/icon.png
15+Name=Weather
16+Name[aa]=Deesaasa
17+Name[am]=የ አየር ንብረት
18+Name[ar]=الطقس
19+Name[ast]=Meteoroloxía
20+Name[be]=Надвор’е
21+Name[br]=Amzer
22+Name[bs]=Vrijeme
23+Name[ca]=El temps
24+Name[cs]=Počasí
25+Name[cy]=Tywydd
26+Name[da]=Vejret
27+Name[de]=Wetter
28+Name[el]=Καιρός
29+Name[en_AU]=Weather
30+Name[en_GB]=Weather
31+Name[eo]=Vetero
32+Name[es]=Meteorología
33+Name[fa]=آب و هوا
34+Name[fi]=Sää
35+Name[fo]=Veðrið
36+Name[fr]=Météo
37+Name[fr_CA]=Météo
38+Name[gd]=An aimsir
39+Name[gl]=O Tempo
40+Name[he]=מזג אוויר
41+Name[hr]=Vrijeme
42+Name[hu]=Időjárás
43+Name[it]=Meteo
44+Name[ja]=天気
45+Name[ko]=날씨
46+Name[lv]=Laikapstākļi
47+Name[my]=ရာသီဥတု
48+Name[nb]=Vær
49+Name[nl]=Weer
50+Name[oc]=Metèo
51+Name[pl]=Pogoda
52+Name[pt]=Meteorologia
53+Name[ro]=Vremea
54+Name[ru]=Погода
55+Name[shn]=ၾိင်ႈၾႃ့
56+Name[sk]=Počasie
57+Name[sl]=Vreme
58+Name[sr]=Време
59+Name[sv]=Väder
60+Name[ta]=வானிலை
61+Name[te]=వాతావరణం
62+Name[tr]=Hava Durumu
63+Name[ug]=ھاۋا رايى
64+Name[uk]=Погода
65+Name[uz]=Ob-havo
66+Name[vi]=Thời tiết
67+Name[zh_CN]=天气
68+Name[zh_TW]=天氣
69+Comment=A weather forecast application for Ubuntu with support for multiple online weather data sources
70+Comment[am]=ለ ኡቡንቱ የ አየር ንብረት መተግበሪያ በርካታ የ አየር ንብረት ዳታ ምንጮች በመስመር ላይ ይደገፋል
71+Comment[ar]=تطبيق توقعات الطقس لأوبونتو مع دعم العديد من مصادر بيانات الطقس على الإنترنت
72+Comment[ast]=Una aplicación de meteoroloxía pa Ubuntu con sofitu pa múltiples fontes de datos climáticos en llinia
73+Comment[be]=Праграма для паказу прагнозаў надвор'я ў Ubuntu. Прадугледжаная падтрымка некалькіх крыніц дадзеных пра надвор'е.
74+Comment[br]=Un arload war Ubuntu evit gouzout petra e vo liv an amzer, hag a gemer e karg meur a vammenn roadennoù meteorologel enlinenn
75+Comment[bs]=Aplikacija za vremensku prognozu za Ubuntu sa podrškom za više izvora o vremenskim podacima
76+Comment[ca]=Aplicació de predicció del temps que funciona amb diverses fonts de dades meteorològiques en línia
77+Comment[cs]=Aplikace předpovědi počasí pro Ubuntu s podporou mnoha online zdrojů
78+Comment[cy]=Ap tywydd ar gyfer Ubuntu sy'n cefnogi sawl ffynhonnell data tywydd arlein
79+Comment[de]=Eine Wettervorhersage-App für Ubuntu mit Unterstützung vieler Online-Wetterdatenquellen
80+Comment[el]=Μια εφαρμογή πρόβλεψης καιρού για το Ubuntu με υποστήριξη πολλαπλών διαδικτυακών πηγών μετεορολογικών δεδομένων
81+Comment[en_AU]=A weather forecast application for Ubuntu with support for multiple online weather data sources
82+Comment[en_GB]=A weather forecast application for Ubuntu with support for multiple online weather data sources
83+Comment[es]=Una aplicación de meteorología para Ubuntu compatible con múltiples fuentes de datos climáticos en línea
84+Comment[fa]=یک برنامه‌ی پیش‌بینی آب‌وهوا برای اوبونتو که از چند منبع داده‌ی آب‌وهوایی پشتیبانی می‌کند
85+Comment[fi]=Useita eri tietolähteitä tukeva sääennustesovellus Ubuntulle
86+Comment[fo]=Eitt veðurvánaforrit til Ubuntu, við stuðul fyri fleiri verðurdátakeldur á alnetinum
87+Comment[fr]=Une application de prévisions météo pour Ubuntu avec prise en charge de plusieurs sources de données météorologiques en ligne
88+Comment[fr_CA]=Une application de prévisions météo pour Ubuntu offrant la prise en charge de plusieurs sources en ligne de données météo
89+Comment[gd]=Aplacaid airson Ubuntu gus ro-aithris air an t-sìde a thoirt dhut o iomadh tùs dàta air loidhne
90+Comment[gl]=Previsión meteorolóxica para Ubuntu con compatibilidade para múltiples orixes de datos en liña
91+Comment[he]=יישום תחזית מזג אוויר לאובונטו עם תמיכה במגוון מקורות נתונים
92+Comment[hr]=Prognoza vremena za Ubuntu s podrškom za višestruke izvore podataka
93+Comment[hu]=Időjárás-előrejelzés alkalmazás Ubuntuhoz, mely több forrásból gyűjt adatokat
94+Comment[it]=Una applicazione per le previsioni meteo di Ubuntu con il supporto a diversi servizi meteorologici online
95+Comment[ja]=複数のオンライン気象データに対応したUbuntu用天気予報アプリ
96+Comment[ko]=우분투를 위한 온라인 날씨 예보 애플리케이션
97+Comment[lv]=Laika prognožu lietotne Ubuntu videi, kas atbalsta vairākus tiešsaistes laikapstākļu datu avotus
98+Comment[my]=Onlineမှများစွာ​သော မိုး​လေဝသ အချက်​အလက်​ များဖြင်​့​ထောက်​ပံ့​ပေးထားသည်​့ Ubuntuအတွက်​ မိုး​လေဝသခန်​့မှန်​းသည်​့application
99+Comment[nb]=Et værmeldingsprogram for Ubuntu med mulighet for å lese værdata fra flere kilder på nett
100+Comment[nl]=Een weersverwachtingsapp voor Ubuntu met ondersteuning voor meerdere online weersinformatiebronnen
101+Comment[pl]=Aplikacja prognozy pogody dla Ubuntu z obsługą wielu internetowych danych pogodowych
102+Comment[pt]=Uma app de meteorologia para o Ubuntu com suporte múltiplo a fontes online
103+Comment[ro]=O aplicație Ubuntu pentru prognoza vremii care funcționează cu mai multe surse de date online pentru vreme
104+Comment[ru]=Приложение для Ubuntu, предоставляющее данные о погоде из нескольких интерактивных источников.
105+Comment[sk]=Aplikácia na predpoveď počasia pre Ubuntu s podporou viacerých online zdrojov počasia
106+Comment[sl]=Program vremenske napovedi za Ubuntu s podporo večim spletnim virom z vremenskimi podatki
107+Comment[sr]=Програм за временску прогнозу за Убунту са подршком за више извора података о времену са интернета
108+Comment[sv]=Ett Ubuntuprogram för väderprognoser med stöd för flera väderdatakällor på nätet
109+Comment[tr]=Birçok çevrimiçi hava durumu veri kaynağı destekli Ubuntu için hava tahmini uygulaması
110+Comment[ug]=توردىكى نۇرغۇن ھاۋارايى مەنبەلىرىنى قوللايدىغان ئۇبۇنتۇنىڭ ھاۋارايىدىن ئالدىن مەلۇمات بېرىش پروگراممىسى
111+Comment[uk]=Програма для показу прогнозів погоди в Ubuntu. Передбачено підтримку декількох джерел даних щодо погоди.
112+Comment[uz]=Ubuntu uchun k'op sonli onlayn ma'lumot manbalarini qo'llab quvvatlovchi ob-havo bashorati dasturi
113+Comment[vi]=Phần mềm dự báo thời tiết cho Ubuntu có hỗ trợ nhiều nguồn số liệu về thời tiết trực tuyến
114+Comment[zh_CN]=一款支持多个在线数据源的 Ubuntu 版天气预报应用
115+Comment[zh_TW]=Ubuntu 的天氣預測桯式,支援多個天氣資料提供者
116+Keywords=weather;forecast;twc;openweathermap;the weather channel;
117+Keywords[am]=የ አየር ንብረት: ግምት: twc;openweathermap የ አየር ንብረት ጣቢያ:
118+Keywords[ar]=طقس;الطقس;توقعات;
119+Keywords[ast]=meteoroloxía;pronósticu;twc;openweathermap;the weather channel;
120+Keywords[be]=надвор'е;прагноз;weather;forecast;twc;openweathermap;the weather channel;
121+Keywords[br]=amzer;rakwelet;twc;openweathermap;chadenn an amzer;
122+Keywords[bs]=vrijeme;prognoza;twc;openweathermap;the weather channel;
123+Keywords[ca]=el temps;predicció;meteorologia;openweathermap;the weather channel;twc;
124+Keywords[cs]=počasí;předpověď;twc;openweathermat;the weather channel;
125+Keywords[cy]=tywydd;rhagolwg;twc;openweathermap;the weather channel;
126+Keywords[de]=Wetter;Vorhersage;openweathermap;the weather channel;
127+Keywords[el]=καιρός;μετεωρολογία;δελτίο καιρού;πρόγνωση;
128+Keywords[en_AU]=weather;forecast;twc;openweathermap;the weather channel;
129+Keywords[en_GB]=weather;forecast;twc;openweathermap;the weather channel;
130+Keywords[es]=clima;meteo;pronóstico;twc;openweathermap;the weather channel;
131+Keywords[fa]=آب‌وهوا;پیش‌بینی;twc;openweathermap;کانال آب‌وهوا;
132+Keywords[fi]=weather;forecast;twc;openweathermap;the weather channel;sää;ennuste;
133+Keywords[fo]=veður;forsøgn;twc;opnaveðurforrit;veðurrásin
134+Keywords[fr]=météo;temps;prévisions;twc;openweathermap;the weather channel;
135+Keywords[fr_CA]=météo;temps;prévisions;twc;openweathermap;the weather channel;
136+Keywords[gd]=weather;forecast;twc;openweathermap;the weather channel;sìde;aimsir;ro-aithris
137+Keywords[gl]=tempo;clima;weather channel;previsión;prognóstico;openweathermap;
138+Keywords[he]=מזג אוויר;תחזית;ערוץ מזג האוויר;מזג אוויר פתוח;
139+Keywords[hr]=weather;forecast;twc;openweathermap;the weather channel;
140+Keywords[hu]=időjárás;előrejelzés;twc;openweathermap;the weather channel;
141+Keywords[it]=meteo;previsioni;the weather channel;openweathermap;
142+Keywords[ja]=weather;forecast;twc;openweathermap;the weather channel;天気;天気予報;ウェザーチャンネル;
143+Keywords[ko]=날씨;예보;기온;강우
144+Keywords[lv]=laiks;laikapstākļi;prognozes;twc;openweathermap;laikapstākļu kanāls;
145+Keywords[my]=မိုး​လေဝသ;ခန်​့မှန်​းချက်​;twc;မိုး​လေဝသဆိုင်​ရာ​မြေပုံကိုဖွင်​့;မိုး​လေဝသ channel;
146+Keywords[nb]=vær;værmelding;openweathermap;the weather channel;
147+Keywords[nl]=weather;forecast;twc;openweathermap;the weather channel;weer;weersverwachting;weerkanaal;
148+Keywords[oc]=metèo;temps;previsions;twc;openweathermap;the weather channel;
149+Keywords[pl]=pogoda;prognoza;twc;openweathermap;kanał z prognozą pogody;
150+Keywords[pt]=meteorologia;previsão;twc;openweathermap;o canal do tempo;
151+Keywords[ro]=vremea;prognoză;twc;openweathermap;the weather channel;
152+Keywords[ru]=погода;прогноз;twc;КартаПогоды;метеослужба;
153+Keywords[sk]=počasie;predpoveď;twc;otvoriťmapupočasia;the weather channel;
154+Keywords[sl]=vreme;napoved;openweathermap;vremenski kanal;
155+Keywords[sr]=време;прогноза;временске прилике;twc;openweathermap;weather channel;
156+Keywords[sv]=väder;prognos;twc;openweathermap;the weather channel;
157+Keywords[tr]=hava durumu;tahmin;twc;openweathermap;the weather channel;
158+Keywords[ug]=ھاۋارايى;ئالدىن مەلۇمات;twc;openweathermap;ھاۋارايى قانىلى;
159+Keywords[uk]=погода;прогноз;weather;forecast;twc;openweathermap;the weather channel;
160+Keywords[uz]=ob-havo;bashorat;twc;openweathermap;the weather channel;
161+Keywords[vi]=thời tiết; dự báo;twc;openweathermap;the weather channel;
162+Keywords[zh_CN]=天气;预报;twc;开源气象服务;天气频道;
163+Keywords[zh_TW]=weather;forecast;twc;openweathermap;the weather channel;天氣;預測;
164+X-Ubuntu-Touch=true
165+X-Ubuntu-Default-Department-ID=accessories
166+X-Ubuntu-StageHint=SideStage
167+X-Ubuntu-Splash-Color=#F5F5F5
168+X-Ubuntu-Splash-Show-Header=true
169+X-Ubuntu-Supported-Orientations=portrait
170
171=== added directory 'snap'
172=== added directory 'snap/ubuntu-app-platform'
173=== added file 'snapcraft.yaml'
174--- snapcraft.yaml 1970-01-01 00:00:00 +0000
175+++ snapcraft.yaml 2016-11-24 11:01:07 +0000
176@@ -0,0 +1,33 @@
177+name: ubuntu-weather-app
178+version: '0.1'
179+summary: ubuntu weather app.
180+description: |
181+ A weather forecast application for Ubuntu with support for multiple online weather data sources.
182+grade: devel
183+confinement: devmode
184+architectures: [all]
185+
186+apps:
187+ ubuntu-weather-app:
188+ command: desktop-launch qmlscene --desktop_file_hint=unity8 $SNAP/usr/share/ubuntu-weather-app/app/ubuntu-weather-app.qml
189+ plugs: [unity7, platform, opengl, home, gsettings]
190+
191+plugs:
192+ platform:
193+ interface: content
194+ content: ubuntu-app-platform1
195+ target: ubuntu-app-platform
196+ default-provider: ubuntu-app-platform
197+
198+parts:
199+ ubuntu-weather-app:
200+ plugin: cmake
201+ configflags: [-DCMAKE_INSTALL_PREFIX=/usr, -DCLICK_MODE=off]
202+ source: .
203+ build-packages:
204+ - cmake
205+ - intltool
206+ after: [desktop-ubuntu-app-platform]
207+ environment:
208+ source: snap/
209+ plugin: dump

Subscribers

People subscribed via source and target branches

to all changes: