Merge lp:~gary-wzl77/ubuntu-calendar-app/fix-1428036 into lp:ubuntu-calendar-app

[Gary.Wang]

Fix 1428036

[Alan Pope 🍺🐧🐱 🦄 (popey)]

In en_GB this is pretty tight on a low resolution display like the bq e4.5.

Here's the current calendar app:-
http://people.canonical.com/~alan/screenshots/device-2015-06-02-120425.png

This is what it looks like with your change:-
http://people.canonical.com/~alan/screenshots/device-2015-06-02-120540.png

Could be even more tight in other languages.

[Gary.Wang (gary-wzl77)]

> In en_GB this is pretty tight on a low resolution display like the bq e4.5.
>
> Here's the current calendar app:-
> http://people.canonical.com/~alan/screenshots/device-2015-06-02-120425.png
>
> This is what it looks like with your change:-
> http://people.canonical.com/~alan/screenshots/device-2015-06-02-120540.png
>
> Could be even more tight in other languages.

Quick review on zh_CN on bq e4.5
Yeah, same case for zh_CN, pretty tight.Almost no space for each items on the header.
hmm.......
I think it gonna be quite bad to check on this according to different locale.
However current implementation was broken in several locale.
Any ideas?

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Can we use Locale.NarrowFormat?

http://doc.qt.io/qt-5/qml-qtqml-locale.html#formattype

"Locale.NarrowFormat A special version of day and month names for use when space is limited; for example, returning "J" as a month name. Note that the narrow format might contain the same text for different months and days or it can even be an empty string if the locale doesn't support narrow names, so you should avoid using it for date formatting. Also, for the system locale this format is the same as ShortFormat."

[Gary.Wang (gary-wzl77)]

Looks good after using Locale.NarrowFormat.
Thanks for your good reminder.
Pls check the screenshots as following for three different locale.

en_UK : https://drive.google.com/open?id=0B2H9ECPSSfqIcFYybldnakdLNEE&authuser=1
zh_CN : https://drive.google.com/open?id=0B2H9ECPSSfqIdnJUYUFXQjVOc28&authuser=1
he_IL : https://drive.google.com/open?id=0B2H9ECPSSfqIODJzMEtmZFAwTEk&authuser=1

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Looks great! Thanks Gary!

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/518/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2898
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2898/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-utopic-amd64-autolanding/303
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-autolanding/91

review: Needs Fixing (continuous-integration)

[Alan Pope 🍺🐧🐱 🦄 (popey)]

This broke the autopilot test by removing the label from the field it seems.

"AttributeError: Class 'Label' has no attribute 'day'."

review: Needs Fixing

[lp:~gary-wzl77/ubuntu-calendar-app/fix-1428036]

661. By Gary.Wang on 2015-06-09

Add day property to avoid autopilot test broken

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Yup, that fixed it. Thanks.

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'MonthComponent.qml'
--- MonthComponent.qml	2015-03-05 21:59:16 +0000
+++ MonthComponent.qml	2015-06-09 10:46:15 +0000
@@ -233,8 +233,8 @@
             id: weekDay
             objectName: "weekDay" + index
             width: parent.dayWidth
-            property var day :Qt.locale().standaloneDayName(( Qt.locale().firstDayOfWeek + index), Locale.ShortFormat)
-            text: isYearView ? day.charAt(0) : day;
+            property var day : Qt.locale(Qt.locale().name).standaloneDayName(( Qt.locale().firstDayOfWeek + index), Locale.ShortFormat);
+            text: isYearView ? Qt.locale(Qt.locale().name).standaloneDayName(( Qt.locale().firstDayOfWeek + index), Locale.NarrowFormat) : day
             horizontalAlignment: Text.AlignHCenter
             font.pixelSize: intern.dayFontSize
             font.bold: true

=== modified file 'po/com.ubuntu.calendar.pot'
--- po/com.ubuntu.calendar.pot	2015-06-01 08:54:59 +0000
+++ po/com.ubuntu.calendar.pot	2015-06-09 10:46:15 +0000
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2015-06-01 16:53+0800\n"
+"POT-Creation-Date: 2015-06-09 18:44+0800\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[e-mail]>\n"