Merge ~gary-wzl77/ubuntu-app-platform:cjk_font into ubuntu-app-platform:master

Proposed by Gary.Wang
Status: Merged
Approved by: Tim Peeters
Approved revision: 243302a8016faa9cc9af7286510d2f9fda8d160f
Merge reported by: Tim Peeters
Merged at revision: not available
Proposed branch: ~gary-wzl77/ubuntu-app-platform:cjk_font
Merge into: ubuntu-app-platform:master
Diff against target: 13 lines (+2/-0)
1 file modified
snapcraft.yaml (+2/-0)
Reviewer Review Type Date Requested Status
Tim Peeters Approve
Review via email: mp+312021@code.launchpad.net

Commit message

Add a droid derived Sans-Seri style CJK font to make Chinese/Japanese/Korean characters display correctly.

Description of the change

Fixed lp:1645611
Add a droid derived Sans-Seri style CJK font to make Chinese/Japanese/Korean characters display correctly.
We add the CJK font in stage-package in ubuntu-app-platform so that we don't need to modify yaml files for each app. At the same time, app package size will remain the same without growing if CJK font is snapped in ubuntu-app-platform, instead of each app.

To post a comment you must log in.
Revision history for this message
Tim Peeters (tpeeters) wrote :

Thanks for the MR.

When I look at http://packages.ubuntu.com/search?keywords=ttf-wqy-microhei it seems that this was the package name in precise, and in newer releases the description says it is a dummy package. I think it is better to use the name of the new package directly.

Also there is a typo (copied from the precise package name), the 'f' missing at the end of sans-serif.

review: Needs Fixing
243302a... by Gary.Wang

Use the name of latest font package and fixed typo.

Revision history for this message
Tim Peeters (tpeeters) wrote :

Looks good now, thanks.

review: Approve
Revision history for this message
Tim Peeters (tpeeters) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 534fe16..8a890c6 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -96,6 +96,8 @@ parts:
6 # Needed by telegram.
7 - qml-module-ubuntu-connectivity
8 - qtdeclarative5-ubuntu-contacts0.1
9+ # Add a droid derived Sans-Serif style CJK font
10+ - fonts-wqy-microhei
11
12 snap:
13 - etc

Subscribers

People subscribed via source and target branches

to all changes: