Telegram app

Merge lp:~gary-wzl77/telegram-app/snap-minize-pkg-size into lp:telegram-app

  1. snap-minize-pkg-size
  2. Merge into telegram
Proposed by Gary.Wang
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: 257
Merged at revision: 256
Proposed branch: lp:~gary-wzl77/telegram-app/snap-minize-pkg-size
Merge into: lp:telegram-app
Prerequisite: lp:~libqtelegram-team/telegram-app/snap-telegram-app-take3
Diff against target: 75 lines (+20/-12)
1 file modified
snapcraft.yaml (+20/-12)
To merge this branch: bzr merge lp:~gary-wzl77/telegram-app/snap-minize-pkg-size
Reviewer Review Type Date Requested Status
Jin (community) Approve
Roberto Mier Escandon (community) Approve
Review via email: mp+311903@code.launchpad.net

Commit message

1.use the ubuntu-app-platform interface to minimize the package size(3.1MB)
2.only stage necessary libraries and qml files.
3.simplify yaml file.

Description of the change

1.use the ubuntu-app-platform interface to minimize the package size(3.1MB)
2.only stage necessary libraries and qml files.
3.simplify yaml file.

To post a comment you must log in.
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

Old Size: 69Mb
New Size: 3.1Mb
Result: WOW!!

Obviosuly approved. Great work!

review: Approve
Revision history for this message
Jin (jindallo) wrote :

Patch looks good,
I will merge.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'snapcraft.yaml'
2--- snapcraft.yaml 2016-11-28 02:23:09 +0000
3+++ snapcraft.yaml 2016-11-28 02:23:09 +0000
4@@ -32,11 +32,8 @@
5 build-packages:
6 - build-essential
7 - libssl-dev
8+ - qtbase5-dev
9 - qtmultimedia5-dev
10- stage-packages:
11- - libthumbnailer-qt-dev
12- - qml-module-ubuntu-connectivity
13- - qtdeclarative5-ubuntu-contacts0.1
14
15 telegramqml:
16 source: https://github.com/Aseman-Land/TelegramQML.git
17@@ -46,9 +43,7 @@
18 qt-version: qt5
19 options:
20 - INCLUDEPATH+=$SNAPCRAFT_STAGE/usr/include/libqtelegram-ae
21- - INCLUDEPATH+=$SNAPCRAFT_STAGE/usr/include/thumbnailer-qt-1.0/unity/thumbnailer/qt
22- - LIBS+=-Lqtelegram-ae
23- - LIBS+=-Lthumbnailer-qt
24+ - INCLUDEPATH+=/usr/include/thumbnailer-qt-1.0/unity/thumbnailer/qt
25 - PREFIX=/usr
26 - -r
27 - BUILD_MODE+=lib
28@@ -56,10 +51,11 @@
29 # FIXME: workaround for skip gcc 6 build issue with stdlib.h
30 - QMAKE_CFLAGS_ISYSTEM=
31 build-packages:
32+ - build-essential
33 - intltool
34+ - qtbase5-dev
35 - qtdeclarative5-dev
36- - qt5-default
37- - qtbase5-dev
38+ - libthumbnailer-qt-dev
39 after: [libqtelegram-ae]
40
41 telegram-app:
42@@ -74,18 +70,30 @@
43 - DEFINES+=SNAP_MODE
44 - -r
45 snap:
46+ # bin
47+ - lib/x86_64-linux-gnu/bin/telegram
48+ #external library
49+ - usr/lib/*/libqtelegram-ae.so.*
50+ - usr/lib/*/libtelegramqml.so.*
51+ #Connectivity
52+ - usr/lib/*/qt5/qml/Ubuntu/Connectivity/libconnectivity-qml.so
53+ - usr/lib/*/qt5/qml/Ubuntu/Connectivity/qmldir
54+ #Contacts
55+ - usr/lib/*/qt5/qml/Ubuntu/Contacts.0.1/
56+ - usr/share/doc/qtdeclarative5-ubuntu-contacts0.1/copyright
57 - -database
58 - -emojis
59 - -icons
60 - -scope
61 - -stickers
62+ stage-packages:
63+ - qml-module-ubuntu-connectivity
64+ - qtdeclarative5-ubuntu-contacts0.1
65 after: [telegramqml, desktop-ubuntu-app-platform]
66
67 wrapper:
68- source: snap
69+ source: snap/
70 plugin: dump
71 organize:
72 telegram-app.wrapper: bin/telegram-app.wrapper
73
74-
75-

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: