~gary-wzl77/snappy-hwe-snaps/+git/ubuntu-custom-image:some_fixes_from_feedback

Last commit made on 2017-11-17
Get this branch:
git clone -b some_fixes_from_feedback https://git.launchpad.net/~gary-wzl77/snappy-hwe-snaps/+git/ubuntu-custom-image
Only Gary.Wang can upload to this branch. If you are Gary.Wang please log in for upload directions.

Branch merges

Branch information

Name:
some_fixes_from_feedback
Repository:
lp:~gary-wzl77/snappy-hwe-snaps/+git/ubuntu-custom-image

Recent commits

9212041... by Gary.Wang on 2017-11-17

Specify the working dir with the correct command line argument.

We also remove the cesg archive username and password in hohhot example
to prevent sensitive information leaking.

9b867e1... by System Enablement CI Bot <email address hidden> on 2017-11-17

Merge remote tracking branch better_code_coverage

Merge-Proposal: https://code.launchpad.net/~gary-wzl77/snappy-hwe-snaps/+git/ubuntu-custom-image/+merge/333803

Author: Gary.Wang <email address hidden>

Add bunch of unit tests to improve code coverage in main
We have poor code coverage percentage in main.py. The added unit tests ensure
every code snippets in main.py can be tested.

Here is the current code coverage statistics. We're pretty close to eventual 100% code coverage.
http://paste.ubuntu.com/25973624/

169d3a9... by Gary.Wang on 2017-11-16

Merge git+ssh://git.launchpad.net//~snappy-hwe-team/snappy-hwe-snaps/+git/ubuntu-custom-image into code_coverage_main

7cbb654... by Gary.Wang on 2017-11-16

Add a couple of unit tests for gadget specification error handling and
some cleanups.

d8f5df9... by Gary.Wang on 2017-11-16

Move ImageCreationMocker to helper so it can be reused by others.

fd1d70f... by Gary.Wang on 2017-11-16

Address the review comments.

91a1b6a... by Gary.Wang on 2017-11-15

Image assembler unit tests refine.

Add three more test cases for a good code coverage[raw_hooks, image
 file location test(output_dir), hooks_directory argument in ubuntu_image].
Also Return subprocess exit info when mocking classic image creation.

313b411... by Gary.Wang on 2017-11-14

Update the test cases a bit as test data location is changed, also some
cleanups. Some logic fine-tuned on member variables initialization.

b617137... by Gary.Wang on 2017-11-14

Run subprocess_run normally in ImageCreationMock if it's not intended
to create a classic image.

2f1093f... by Gary.Wang on 2017-11-13

Test return value(exit_code) with assertEquals.