~gary-wzl77/snappy-hwe-snaps/+git/ubuntu-custom-image:import_correct_pkg

Last commit made on 2017-11-10
Get this branch:
git clone -b import_correct_pkg https://git.launchpad.net/~gary-wzl77/snappy-hwe-snaps/+git/ubuntu-custom-image
Only Gary.Wang can upload to this branch. If you are Gary.Wang please log in for upload directions.

Branch merges

Branch information

Name:
import_correct_pkg
Repository:
lp:~gary-wzl77/snappy-hwe-snaps/+git/ubuntu-custom-image

Recent commits

23800a2... by Gary.Wang

More fixes for unified package naming in the whole project, including
some env variables.

b95b8f3... by Gary.Wang

Import the correct package and remove unused imports.

When writing test cases, I found we're importing old packages(ubuntu_image)
wrongly in some files. It blocked us to use classes or functions defined from
these files when importing them in other source files, e.g. LogCapture
Also we didn't copy all source files of ubuntu_image into this repo since
they're not needed for image customizations, hence we remove some deprecated
Builders(i.e XXXClassicBuilder, XXXModelAssertionBuilder) which are intended to
facilitate writing test cases for ubuntu-image instead of ubuntu-custom-image.

c1e2196... by Gary.Wang

Don't double log error and only throw an exception.

7da59e8... by Gary.Wang

Fix wrong member variable name and add one more test case for NoneType
checking(extra_snaps).

581b692... by Gary.Wang

Move CustomBuilder into ImageAssembler and explicitly return non-zero if an error occurs.

a668942... by Gary.Wang

Fix failing unit tests and flake8 warnings, also a few test cases tweaks
for a better code coverage.

a194474... by Gary.Wang

Address some issues per the review comments.

0bb0865... by Gary.Wang

Implement ImageAssembler to move all image creation related logic into it.

Move parse_spec and prepare_image out of CustomBuilder and implement the
related logic in the new implemented Module(ImageAssembler).
We catch the ImageSpecError exception in main once something flaky
occurs during the specs parsing. Also rename classic_build to build_classic_image.

1fc7ea7... by Gary.Wang

Accessing the index via enumerate and leave loop early.

ed4b054... by Gary.Wang

Don't throw an exception when extra-snaps is empty.