Code review comment for lp:~gary-wzl77/scope-aggregator/force_display_results

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hi Gary,

Is this functionality required for the BW scope (to work with a specific child scope we did not write)?

If this functionality is required then we should merge it because we do not want to fork scope-aggegator, and BW may need to be updated later from s-a new releases.

However, I think this whole "only_in_search" functionality is a work around (hack) that we needed for BW to work with a child scope we did not write (right?). If so, I doubt we will ever need this functionality again. Therefore: if you agree with this analysis, I propose that you modify the README and add a comment saying this json key is "deprecated and exists only to support a special case".

review: Needs Fixing

« Back to merge proposal