Merge lp:~gary-wzl77/account-plugins/mcloud-user-agent into lp:account-plugins

Proposed by Gary.Wang on 2016-08-29
Status: Merged
Approved by: Alberto Mardegan on 2016-08-29
Approved revision: 169
Merged at revision: 172
Proposed branch: lp:~gary-wzl77/account-plugins/mcloud-user-agent
Merge into: lp:account-plugins
Prerequisite: lp:~mardy/account-plugins/mcloud-plugin-lp1587282
Diff against target: 12 lines (+1/-0)
1 file modified
qml/mcloud/Main.qml (+1/-0)
To merge this branch: bzr merge lp:~gary-wzl77/account-plugins/mcloud-user-agent
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) 2016-08-29 Approve on 2016-08-29
Review via email: mp+304213@code.launchpad.net

Commit message

Add a fixed userAgent.

Currently, userAgent of oxide for touch contains 'Android' string. Cmcc authentication server will review IP address and login location for security reason in such a case. We also found that end-user who try to login outside of China are struggling with mcloud authentication. In most cases, after at least 5 times attempts, user can pass through it.
 Adding user-agent makes the login from phone just like login from tablet or PC, which prevents cmcc authentication server from triggering such a secure mechanism.

Description of the change

Add a fixed userAgent.

Currently, userAgent of oxide for touch contains 'Android' string. Cmcc authentication server will review IP address and login location for security reason in such a case. We also found that end-user who try to login outside of China are struggling with mcloud authentication. In most cases, after at least 5 times attempts, user can pass through it.
 Adding user-agent makes the login from phone just like login from tablet or PC, which prevents cmcc authentication server from triggering such a secure mechanism.

To post a comment you must log in.
Alberto Mardegan (mardy) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/icons/mcloud.png'
2Binary files data/icons/mcloud.png 2016-08-29 02:36:30 +0000 and data/icons/mcloud.png 2016-08-29 02:36:30 +0000 differ
3=== modified file 'qml/mcloud/Main.qml'
4--- qml/mcloud/Main.qml 2016-08-29 02:36:30 +0000
5+++ qml/mcloud/Main.qml 2016-08-29 02:36:30 +0000
6@@ -2,5 +2,6 @@
7
8 OAuthMain {
9 creationComponent: OAuth {
10+ userAgent: "Mozilla/5.0 (Linux; Ubuntu 15.04) AppleWebKit/537.36 Chromium/51.0.2704.79 Safari/537.36"
11 }
12 }

Subscribers

People subscribed via source and target branches

to all changes: