Merge lp:~gary-lasker/unity/software-center-launcher-integration-tests-for-5.0 into lp:unity/5.0

Proposed by Gary Lasker
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 2386
Merged at revision: 2391
Proposed branch: lp:~gary-lasker/unity/software-center-launcher-integration-tests-for-5.0
Merge into: lp:unity/5.0
Prerequisite: lp:~bilalakhtar/unity/5.0series-sru-software-center-integration-fixes
Diff against target: 124 lines (+104/-16)
1 file modified
manual-tests/SoftwareCenter.txt (+104/-16)
To merge this branch: bzr merge lp:~gary-lasker/unity/software-center-launcher-integration-tests-for-5.0
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Brandon Schaefer (community) Approve
Christopher Lee (community) Approve
Review via email: mp+114241@code.launchpad.net

Commit message

manual-tests/SoftwareCenter.txt: added tests for Ubuntu Software Center/Unity launcher integration feature

Description of the change

This branch provides a set of manual tests for the Ubuntu Software Center/Unity launcher integration feature. It actually updates the manual test that is currently found in the branch and adds additional needed detailed test cases.

There are *no* code changes here. All changes are limited to the file manual-tests/SoftwareCenter.txt.

Please note that this kind of manual testing is very useful for this feature as it spans two applications and so all pf the details of the interactions can be tested directly by these. Of course, these manual tests are *not* to be considered in lieu of complete automatic unit tests! Rather, they are simply intended to augment the automatic unit tests that are already in place for this integration feature on the Unity and Software Center sides. The advantage of having manual tests for this feature is that a person can more easily observe in detail the overall interaction between the two applications.

The added tests will thoroughly verify all of the pieces of the integration functionality for the various cases (install/remove/cancel of archive applications, purchased items, installing items from the "Independent" repository) , and cover all of the bug fixes for Unity branch https://code.launchpad.net/~bilalakhtar/unity/5.0series-sru-software-center-integration-fixes/+merge/110214 and the corresponding Software Center branch https://code.launchpad.net/~gary-lasker/software-center/unity-launcher-integration-fixes

Finally, I've set this branch as depending on Bilal's ~bilalakhtar/unity/5.0series-sru-software-center-integration-fixes, as the test cases assume the fixes in his branch.

Many thanks for your review!

To post a comment you must log in.
Gary Lasker (gary-lasker) wrote :

P.S. It would be nice, if you decide to merge these tests, to also get them into trunk. Will a second MP be needed for that? Or do you automatically merge 5.0 changes to trunk?

Please let me know and I will write a second proposal if needed.

Thanks again!

Christopher Lee (veebers) wrote :

Hi Gary,

I stepped through the instructions but had to do something different to get the 'More Info' option. I think this needs to be made a bit more explicit so it doesn't confuse anyone.

The default view that I get when selecting the 'Games' category is a list of genres and the top rated games (clicking on any of these games takes me to its details, no 'More Info' available).

I had to select a genre to get a list of games which allowed me to select it and get the 'More Info' option.

If you could clarify that please.

Gary Lasker (gary-lasker) wrote :

Hello Christopher! Thanks very much for reviewing this so carefully, I really appreciate it! Indeed, the section for selecting a game is unclear in exactly the way you described. I've updated the branch and hopefully now it is clarified.

Thank you again and please let me know if there are any other changes needed!

Best regards,
Gary

Christopher Lee (veebers) wrote :

No worries Gary :) Looks good.

review: Approve
Unity Merger (unity-merger) wrote :
Brandon Schaefer (brandontschaefer) wrote :

Hmm the last manual test didn't work for me. When you remove a program that icon still stays in the the launcher.

review: Needs Fixing
Gary Lasker (gary-lasker) wrote :

Hi Brandon, and thanks very much for testing this. Actually, you need to be using the corresponding updated version of Software Center as well for the integration to fully work. This can be found in my branch here:

  lp:~gary-lasker/software-center/unity-launcher-integration-fixes

I have a test build of this currently building in my PPA so that it's easier to get and use, but feel free to use the branch directly. To run it, simply get a copy of the branch above and run as follows from the top level of the branch:

  $ ./software-center

I'll add a note here when my PPA build is complete.

Thanks again!
Gary

Brandon Schaefer (brandontschaefer) wrote :

Opps! Sorry, missed that in the info above! (Retesting) annd it works :).

review: Approve
Marco Trevisan (Treviño) (3v1n0) wrote :

+ The game begins to install and the progress bar moves in Software Center.
37 + At the very *end* of the installation process (when the progress bar has completed), the icon for the game "flies" into the Unity Launcher.

Mhm... shouldn't the fly happen when the installation process begins?

Bilal Akhtar (bilalakhtar) wrote :

On Mon, Jul 16, 2012 at 1:21 PM, Marco Trevisan (Treviño)
<mail@3v1n0.net> wrote:
>
> Mhm... shouldn't the fly happen when the installation process begins?

Not any more. Gary's software-center branch (linked above) makes the change.

> --
> https://code.launchpad.net/~gary-lasker/unity/software-center-launcher-integration-tests-for-5.0/+merge/114241
> You are subscribed to branch lp:~bilalakhtar/unity/5.0series-sru-software-center-integration-fixes.

Gary Lasker (gary-lasker) wrote :

Hi Marco and Bilal, yes, in order to fix a few important bugs we had to move the icon flying event to happen at the very end of the application install rather than at the beginning. For Quantal (still TODO), we will want to revert this behavior -- I believe to do that we just need some additional support for reacting aptdaemon events on the Unity side (see bug 1011681, and please correct me if there is more than that, Bilal).

In the meantime, this delay has been deemed a worthy compromise by the user experience folks based on the number of high-target bugs we are fixing with this.

Thanks all for your help!!
Gary

Gary Lasker (gary-lasker) wrote :

And thanks to you also, Brandon!! I appreciate your retesting!

Just fyi, I prepared a test version of Ubuntu Software Center that includes this functionality and it is now ready in my PPA at:

  https://launchpad.net/~gary-lasker/+archive/ppa

The version of interest is the one for Precise, version 5.2.5~unitylaunchertest1.

Marco Trevisan (Treviño) (3v1n0) wrote :

Fine for me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'manual-tests/SoftwareCenter.txt'
2--- manual-tests/SoftwareCenter.txt 2012-04-26 08:07:45 +0000
3+++ manual-tests/SoftwareCenter.txt 2012-07-12 14:54:19 +0000
4@@ -1,16 +1,104 @@
5-The SoftwareCenter Launcher Integration cancel
6-----------------------------------------------
7-
8-Setup:
9-#. Open software-center
10-
11-Actions:
12-#. Click on install on a big application like wesnoth
13-#. Verify that the icon "flies" into the launcher
14-#. Wait until the "In Progress" appears in the toplevel toolbar of s-c
15-#. Click on the "In Progress" button in the toolbar
16-#. Click on the "cancel" button of the install of the application
17-
18-Expected Result:
19- The icon is removed from the launcher again after the download was
20- canceled.
21+
22+Ubuntu Software Center Launcher Integration, installing an application from the Ubuntu archives
23+-----------------------------------------------------------------------------------------------
24+
25+Setup:
26+#. Launch Ubuntu Software Center
27+
28+Actions:
29+#. In Software Center, click on the "Games" category in the left panel to view the display of game genre icons, "Top Rated Games", etc.
30+#. Select the "Card Games" icon and then select any uninstalled game in the displayed list.
31+#. Click the "More Info" button.
32+#. In the details view for the game, click the "Install" button.
33+#. Enter the password for the install when prompted.
34+
35+Expected Result:
36+ The game begins to install and the progress bar moves in Software Center.
37+ At the very *end* of the installation process (when the progress bar has completed), the icon for the game "flies" into the Unity Launcher.
38+ Verify that the icon that has been added to the launcher and that:
39+ - If the Unity launcher was set to auto-hide, it correctly autohides at the end of the installation and is not "stuck" in a displayed state.
40+ - The launcher icon has the correct icon for the game that was installed.
41+ - Hovering the mouse cursor over the icon displays the name of the application for its tooltip (and that it does *not* display the text "Waiting to install").
42+ - Clicking the icon launches the newly installed game.
43+
44+
45+Ubuntu Software Center Launcher Integration, cancelling an installation
46+-----------------------------------------------------------------------
47+
48+Setup:
49+#. Launch Ubuntu Software Center
50+
51+Actions:
52+#. In Software Center, click on the "Games" category in the left panel to view the display of game genre icons, "Top Rated Games", etc.
53+#. Select the "Card Games" icon and then select any uninstalled game in the displayed list.
54+#. Click the "More Info" button.
55+#. In the details view for the game, click the "Install" button.
56+#. In the dialog that prompts you to enter your password for the install, click the "Cancel" button.
57+
58+Expected Result:
59+ The installation is cancelled. Verify that no icon has been added to the Unity launcher integration.
60+
61+
62+Ubuntu Software Center Launcher Integration, installing a purchased application
63+-------------------------------------------------------------------------------
64+
65+Setup:
66+#. Launch Ubuntu Software Center
67+
68+Actions:
69+#. In Software Center, click the down arrow in the toolbar next to the "All Software" button, and choose the "For Purchase" item.
70+#. In the list of displayed items for purchase, choose an application (not a magazine or book) that is free (that is, marked as $0 -- unless you wish to purchase something).
71+#. Click the "More Info" button.
72+#. In the details view for the application, click the "Buy" button.
73+#. Follow the purchase process. For a $0 item, you will not be prompted for payment information.
74+#. Enter the password for the install when prompted.
75+
76+Expected Result:
77+ The the progress bar activates in Software Center. Note that for purchased items, it can take a bit of time before the progress bar transitions from intdeterminate to determinate.
78+ At the very *end* of the installation process (when the progress bar has completed), the icon for the purchased item "flies" into the Unity Launcher.
79+ Verify that the icon that has been added to the launcher and that:
80+ - If the Unity launcher was set to auto-hide, it correctly autohides at the end of the installation and is not "stuck" in a displayed state.
81+ - The launcher icon has the correct icon for the application that was installed.
82+ - Hovering the mouse cursor over the icon displays the name of the application for its tooltip (and that it does *not* display the text "Waiting to install").
83+ - Clicking the icon launches the newly installed application.
84+
85+
86+Ubuntu Software Center Launcher Integration, installing from the "Independent" archives
87+---------------------------------------------------------------------------------------
88+
89+Setup:
90+#. Launch Ubuntu Software Center
91+
92+Actions:
93+#. In Software Center, click the down arrow in the toolbar next to the "All Software" button, and choose the "Independent" item.
94+#. In the list of displayed items, choose an application that is not yet installed.
95+#. Click the "More Info" button.
96+#. In the details view for the application, click the "Install" button.
97+#. Enter the password for the install when prompted.
98+
99+xpected Result:
100+ The application begins to install and the progress bar moves in Software Center.
101+ At the very *end* of the installation process (when the progress bar has completed), the icon for the application "flies" into the Unity Launcher.
102+ Verify that the icon that has been added to the launcher and that:
103+ - If the Unity launcher was set to auto-hide, it correctly autohides at the end of the installation and is not "stuck" in a displayed state.
104+ - The launcher icon has the correct icon for the application that was installed.
105+ - Hovering the mouse cursor over the icon displays the name of the application for its tooltip (and that it does *not* display the text "Waiting to install").
106+ - Clicking the icon launches the newly installed game.
107+
108+
109+Ubuntu Software Center Launcher Integration, uninstalling an application
110+------------------------------------------------------------------------
111+
112+Setup:
113+#. Launch Ubuntu Software Center
114+
115+Actions:
116+#. In Software Center, click the "Installed" toolbar button to access the list of installed applications.
117+#. Choose an installed application to remove (choose one for which there is a corresponding icon in the Unity launcher).
118+#. Click the "More Info" button.
119+#. In the details view for the application, click the "Remove" button.
120+#. Enter the password for the remove when prompted.
121+
122+Expected Result:
123+ The uninstall process begins and the progress bar moves in Software Center.
124+ At the very *end* of the installation process, verify that the corresponding icon in the Unity launcher is *removed*.

Subscribers

People subscribed via source and target branches

to all changes: