Code review comment for lp:~gary-lasker/software-center/update-to-latest-recommender-client

Revision history for this message
Michael Vogt (mvo) wrote :

On Tue, Aug 28, 2012 at 06:19:29PM -0000, Gary Lasker wrote:
> Hi Michael, and thanks for your review. Your suggestions are good and I've added a separate get_recommender_uuid in utils.py and added a unit test for it.
> You are subscribed to branch lp:software-center.

Thanks for this, I merged this now and added the test for the config
conversion that I put in the previous comment as well. I hope you
don't mind. It will ensure that on any future changes of the config
code this functionality keeps working. I also put the branch name of
the recommender-client into the changelog to make it easier for me to
remember the location.

Cheers,
 Michael

« Back to merge proposal