Merge lp:~gary-lasker/software-center/tos-urls-lp961538 into lp:software-center

Proposed by Gary Lasker
Status: Merged
Merged at revision: 2908
Proposed branch: lp:~gary-lasker/software-center/tos-urls-lp961538
Merge into: lp:software-center
Diff against target: 38 lines (+7/-3)
2 files modified
softwarecenter/enums.py (+5/-2)
softwarecenter/ui/gtk3/dialogs/dialog_tos.py (+2/-1)
To merge this branch: bzr merge lp:~gary-lasker/software-center/tos-urls-lp961538
Reviewer Review Type Date Requested Status
software-store-developers Pending
Review via email: mp+98732@code.launchpad.net

Description of the change

This branch implements Anthony's notes for bug 961538. It fixes the URLs and sets a separate URL for use in a web browser (where header/footers are included) vs. the embedded dialog (where they are not).

Thanks!

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/enums.py'
2--- softwarecenter/enums.py 2012-03-16 09:02:42 +0000
3+++ softwarecenter/enums.py 2012-03-21 20:58:18 +0000
4@@ -52,8 +52,11 @@
5 UBUNTU_SSO_SERVICE = os.environ.get(
6 "USSOC_SERVICE_URL", "https://login.ubuntu.com/api/1.0")
7
8-# the terms-of-service link
9-SOFTWARE_CENTER_TOS_LINK = "http://apps.ubuntu.com/cat/tos"
10+# the terms-of-service links (the first is for display in a web browser
11+# as it has the header and footer, the second is for display in a dialog
12+# as it lacks them and so looks better)
13+SOFTWARE_CENTER_TOS_LINK = "https://apps.ubuntu.com/cat/tos/"
14+SOFTWARE_CENTER_TOS_LINK_NO_HEADER = "https://apps.ubuntu.com/cat/tos/plain/ "
15
16 # version of the database, every time something gets added (like
17 # terms for mime-type) increase this (but keep as a string!)
18
19=== modified file 'softwarecenter/ui/gtk3/dialogs/dialog_tos.py'
20--- softwarecenter/ui/gtk3/dialogs/dialog_tos.py 2012-03-19 14:38:10 +0000
21+++ softwarecenter/ui/gtk3/dialogs/dialog_tos.py 2012-03-21 20:58:18 +0000
22@@ -26,6 +26,7 @@
23
24 from softwarecenter.ui.gtk3.views.webkit import ScrolledWebkitWindow
25 from softwarecenter.ui.gtk3.widgets.spinner import SpinnerNotebook
26+from softwarecenter.enums import SOFTWARE_CENTER_TOS_LINK_NO_HEADER
27
28
29 class DialogTos(Gtk.Dialog):
30@@ -65,7 +66,7 @@
31
32 def run(self):
33 self.spinner.show_spinner()
34- self.webkit.load_uri("http://apps.ubuntu.com/cat/tos")
35+ self.webkit.load_uri(SOFTWARE_CENTER_TOS_LINK_NO_HEADER)
36 return Gtk.Dialog.run(self)
37
38 def _on_load_status_changed(self, view, pspec):

Subscribers

People subscribed via source and target branches