Merge lp:~gary-lasker/software-center/tech-items-to-launcher-fix-lp1006483 into lp:software-center/5.2
Proposed by
Gary Lasker
Status: | Merged |
---|---|
Merged at revision: | 3064 |
Proposed branch: | lp:~gary-lasker/software-center/tech-items-to-launcher-fix-lp1006483 |
Merge into: | lp:software-center/5.2 |
Prerequisite: | lp:~gary-lasker/software-center/unity-launcher-integration-fixes |
Diff against target: |
25 lines (+5/-2) 1 file modified
softwarecenter/ui/gtk3/panes/availablepane.py (+5/-2) |
To merge this branch: | bzr merge lp:~gary-lasker/software-center/tech-items-to-launcher-fix-lp1006483 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
software-store-developers | Pending | ||
Review via email: mp+111135@code.launchpad.net |
Commit message
* lp:~gary-lasker/software-center/tech-items-to-launcher-fix-lp1006483:
- don't add an item to the launcher if its desktop file specifies
NoDisplay=true (LP: #1006483)
Description of the change
This branch fixes bug 1006483 by checking an application's desktop file for NoDisplay=true, and if this value is set, the application is not added to the Unity launcher.
A convenient test case is the Deja Dup package, which sets NoDisplay=true in its desktop file.
To post a comment you must log in.
Thanks, this change looks fine.
It would be nice to have a test for this too, _add_applicatio n_to_unity_ launcher( ) appears to be not covered install/ desktop/ using a n_to_launcher( ) is called for the right desktop files
currently and it would be nice to test it with additional test files in data/app-
mock launcher_info to test that send_applicatio
(should be really straightforward to add I hope).
While looking at this a bit more (trying to figure out if it was covered for not) I noticed that it seems launcher_ integration. py" file needs updating to cover the new behavior that the launcher finished" instead of "transaction- started" .
like the "test_unity_
item is added on "transaction-
It currently sends a fake "transaction- started" signal in the test, but in order to test finished" signal too. finished" signal and also to add a mock pane._add_ application_ to_unity_ launcher so that after to_appdetails_ and_install( test_pkgname) " in the test the test can check that
if the signal is actually delivered to unity it also needs to send a "transaction-
So I would suggest (probably in the original branch or as a seperate branch not here in this branch as this
branch is nice and short) to update the test to send the "transaction-
for available_
self._navigate_
the call was made as expected.
This got a bit long, so the summary is: this branch is fine and approve once the test situation is
sorted out.