Code review comment for lp:~gary-lasker/software-center/sorting-fix-lp969215

Michael Vogt (mvo) wrote :

Thanks for your work on this branch! It works fine and fixes the bug nicely.

Looking at the code (and as I understand it, I may be wrong of course) I would
like to suggest a tweak to the variable name "self.app_view.user_defined_search_sort_method".

- its actually not set when the sort method is changed, but unconditionally once the first
  set of results was displayed. Maybe something like:
- it very similar to "self.user_defined_sort_method" that is set when the sort-method changes

        # when a search changes, this is reset and forces the first
        # result set to be always sorted by relevance
        self.force_default_search_sort_method = True

(of course the logic needs to be inverted with that name change)?

But a more creative ideas for a good name is very welcome of course :) I will approve it now, but
I would like to hear your opinion about the variable.

review: Approve

« Back to merge proposal