Merge lp:~gary-lasker/software-center/search-down-arrow-lp842711 into lp:software-center

[Gary Lasker]

This branch fixes usability bug 842711 by allowing you to use the down arrow to select the first item in the result list a search. This is one of the bugs targeted in the consumer-p-software-center-enhancements blueprint.

Thanks!

[Michael Vogt (mvo)]

Looks great, merging.

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2012-01-10 21:00:13 +0000
+++ debian/changelog	2012-01-12 20:31:23 +0000
@@ -14,8 +14,11 @@
     - do not add an icon to the Unity launcher for packages that do
       not have an Exec entry in their corresponding desktop file,
       e.g. ubuntu-restricted-extras, wine (LP: #913756)
+  * lp:~gary-lasker/software-center/search-down-arrow-lp842711:
+    - select the first item in the result list when the down
+      arrow is pressed during a search (LP: #842711)
 
- -- Gary Lasker <[e-mail]>  Tue, 10 Jan 2012 15:56:44 -0500
+ -- Gary Lasker <[e-mail]>  Thu, 12 Jan 2012 15:18:54 -0500
 
 software-center (5.1.5.1) precise; urgency=low
 

=== modified file 'softwarecenter/ui/gtk3/panes/softwarepane.py'
--- softwarecenter/ui/gtk3/panes/softwarepane.py	2012-01-09 17:28:56 +0000
+++ softwarecenter/ui/gtk3/panes/softwarepane.py	2012-01-12 20:31:23 +0000
@@ -511,6 +511,19 @@
         # use the appview combo
         return self.app_view.get_sort_mode()
 
+    def on_search_entry_key_press_event(self, event):
+        """callback when a key is pressed in the search entry widget"""
+        if not self.is_applist_view_showing():
+            return
+        if ((event.keyval == Gdk.keyval_from_name("Down") or
+            event.keyval == Gdk.keyval_from_name("KP_Down")) and
+            self.is_applist_view_showing() and
+            len(self.app_view.tree_view.get_model()) > 0):
+            # select the first item in the applist search result
+            self.app_view.tree_view.grab_focus()
+            self.app_view.tree_view.set_cursor(Gtk.TreePath(),
+                                                   None, False)
+
     def on_search_terms_changed(self, terms):
         " stub implementation "
         pass

=== modified file 'softwarecenter/ui/gtk3/session/viewmanager.py'
--- softwarecenter/ui/gtk3/session/viewmanager.py	2011-12-07 17:17:31 +0000
+++ softwarecenter/ui/gtk3/session/viewmanager.py	2012-01-12 20:31:23 +0000
@@ -41,6 +41,8 @@
         self.search_entry = SearchEntry()
         self.search_entry.connect(
             "terms-changed", self.on_search_terms_changed)
+        self.search_entry.connect(
+            "key-press-event", self.on_search_entry_key_press_event)
 
         self.back_forward = BackForwardButton()
         self.back_forward.connect(
@@ -80,6 +82,13 @@
         if hasattr(pane, "on_nav_forward_clicked"):
             pane.on_nav_forward_clicked(widget)
         return
+        
+    def on_search_entry_key_press_event(self, widget, event):
+    
+        pane = self.get_current_view_widget()
+        if hasattr(pane, "on_search_entry_key_press_event"):
+            pane.on_search_entry_key_press_event(event)
+        return
 
     def register(self, pane, view_id):
         page_id = self.notebook_view.append_page(