Code review comment for lp:~gary-lasker/software-center/remember-sort-preference-lp966878

Gary Lasker (gary-lasker) wrote :

Indeed, the code needs some cleanup for sure, but at this late stage in the cycle I'm not sure we want to rework these pieces. The reason categories act differently is because the code path is separate and does not use user_defined_sort_method. That's part of what I think we want to fix, we actually do not want to even have to use this variable imo.

So, I think we just need to define clearly what we want sorting to do in each view (the spec probably says this already), and then do that with the simplest implementation possible. As a certain wise man I know has said on many an occasion, it's just a simple matter of programming!


« Back to merge proposal