Code review comment for lp:~gary-lasker/software-center/remember-sort-preference-lp966878

Michael Vogt (mvo) wrote :

On Tue, Apr 10, 2012 at 04:21:23PM -0000, Gary Lasker wrote:
> It actually does switch back to the default of the page when it is needed, afaict, such as when viewing the lists from the "More" buttons in the lobby view. I could not find a place where I didn't want my selected to be simply remembered. But, it's worth more investigation certaintly.
>
> I find not resetting it to default constantly to be a big improvement, personally. :)

Thanks, you are right :) I don't quite understand this in the code, but
the effect is really nice. When switching back and forth I get my sort
method preserved, but when switching to categories or similar I get
the default. Its a bit of a mystery why this is given that I can't see
any bit in the code that resets user_definied_sort_method once its
changed, but I'm too tired today to think about this more.

Thanks again!
 Michael

« Back to merge proposal