Merge lp:~gary-lasker/software-center/recommender-unit-test-updates into lp:software-center
Proposed by
Gary Lasker
Status: | Merged |
---|---|
Merged at revision: | 3131 |
Proposed branch: | lp:~gary-lasker/software-center/recommender-unit-test-updates |
Merge into: | lp:software-center |
Diff against target: |
49 lines (+15/-6) 2 files modified
tests/gtk3/test_catview.py (+4/-1) tests/gtk3/windows.py (+11/-5) |
To merge this branch: | bzr merge lp:~gary-lasker/software-center/recommender-unit-test-updates |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
software-store-developers | Pending | ||
Review via email: mp+121484@code.launchpad.net |
Commit message
* lp:~gary-lasker/software-center/recommender-unit-test-updates:
- update unit test to accomodate the new subcategory that has been
added to the themes and tweaks category
Description of the change
When choosing a subcategory for get_test_
Many thanks for your review!
To post a comment you must log in.
Thanks for your branch.
I looked at the code and I it appears that the place that relies on a specific subcategory is ed_for_ you_display_ recommendations _opted_ in". So I think instead of hardcoding it in window.py view.set_ subcategory( ) or by window_ catview( ) so that in Recommendations TestCase we can explicitely specify
"test_recommend
we should either set it in the test that needs it explicitely via self.subcat_
passing a parameter to get_test_
that the subcategory is required. This makes the connection of what needs it more explicit and window.py more
generic. Could you please update that?