Code review comment for lp:~gary-lasker/software-center/recommender-test-fix

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks, looks good.

The test failed for me when running it initially with the following error:
======================================================================
FAIL: test_recommended_for_you_spinner_display (__main__.RecommendationsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gtk3/test_catview.py", line 162, in test_recommended_for_you_spinner_display
    self.rec_panel.recommended_for_you_content.get_property("visible"))
AssertionError: False is not true

----------------------------------------------------------------------
Ran 9 tests in 19.177s

but subsequent runs worked, it seems to be random, maybe 1 out 5. And I doubt its releated
to this branch so I will merge it. But it would be nice if that could be investigated.

review: Approve

« Back to merge proposal