Merge lp:~gary-lasker/software-center/recommender-profile-uploads-lp944693 into lp:software-center

Proposed by Gary Lasker
Status: Merged
Merged at revision: 2941
Proposed branch: lp:~gary-lasker/software-center/recommender-profile-uploads-lp944693
Merge into: lp:software-center
Diff against target: 71 lines (+15/-19)
1 file modified
softwarecenter/backend/recagent.py (+15/-19)
To merge this branch: bzr merge lp:~gary-lasker/software-center/recommender-profile-uploads-lp944693
Reviewer Review Type Date Requested Status
software-store-developers Pending
Review via email: mp+100483@code.launchpad.net

Description of the change

This is just a very small tweak to use a single call to get_config in the recommender agent. Not sure if it even warrants another merge proposal as it's really just cleanup in the branch just merged, but it can never hurt. ;)

Thanks!

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/backend/recagent.py'
2--- softwarecenter/backend/recagent.py 2012-04-02 16:28:32 +0000
3+++ softwarecenter/backend/recagent.py 2012-04-02 17:40:28 +0000
4@@ -77,6 +77,7 @@
5 def __init__(self, xid=None):
6 GObject.GObject.__init__(self)
7 self.xid = xid
8+ self.config = get_config()
9
10 def query_server_status(self):
11 # build the command
12@@ -95,35 +96,31 @@
13
14 @property
15 def recommender_uuid(self):
16- config = get_config()
17- if config.has_option("general", "recommender_uuid"):
18- recommender_uuid = config.get("general",
19- "recommender_uuid")
20+ if self.config.has_option("general", "recommender_uuid"):
21+ recommender_uuid = self.config.get("general",
22+ "recommender_uuid")
23 else:
24 recommender_uuid = ""
25 return recommender_uuid
26
27 @property
28 def recommender_profile_id(self):
29- config = get_config()
30- if config.has_option("general", "recommender_profile_id"):
31- recommender_profile_id = config.get("general",
32- "recommender_profile_id")
33+ if self.config.has_option("general", "recommender_profile_id"):
34+ recommender_profile_id = self.config.get("general",
35+ "recommender_profile_id")
36 else:
37 recommender_profile_id = ""
38 return recommender_profile_id
39
40 def _set_recommender_profile_id(self, profile_id):
41- config = get_config()
42- if not config.has_section("general"):
43- config.add_section("general")
44- config.set("general", "recommender_profile_id", profile_id)
45+ if not self.config.has_section("general"):
46+ self.config.add_section("general")
47+ self.config.set("general", "recommender_profile_id", profile_id)
48
49 def _set_recommender_uuid(self, uuid):
50- config = get_config()
51- if not config.has_section("general"):
52- config.add_section("general")
53- config.set("general", "recommender_uuid", uuid)
54+ if not self.config.has_section("general"):
55+ self.config.add_section("general")
56+ self.config.set("general", "recommender_uuid", uuid)
57
58 def post_submit_profile(self, db):
59 """ This will post the users profile to the recommender server
60@@ -235,9 +232,8 @@
61 return False
62
63 def opt_out(self):
64- config = get_config()
65- config.set("general", "recommender_uuid", "")
66- config.set("general", "recommender_profile_id", "")
67+ self.config.set("general", "recommender_uuid", "")
68+ self.config.set("general", "recommender_profile_id", "")
69
70 def _on_server_status_data(self, spawner, piston_server_status):
71 self.emit("server-status", piston_server_status)

Subscribers

People subscribed via source and target branches