Hi Michael, thanks as always for your review. Indeed, the first failure is a trivial case related to my other branch lp:~gary-lasker/software-center/recommender-test-fix. That branch contained a change to a method name (to make its purpose more clear), and as it had not yet been merged to trunk yet my new test still used the previous method name. I merged trunk and fixed this line and the test works again now.
I also added comments to both places where I make implicit_feedback calls to the recommender service.
Finally, the second failure above (test_recommended_for_you_spinner_display) is unrelated to any changes that I have made, and as I mentioned in https://code.launchpad.net/~gary-lasker/software-center/recommender-test-fix/+merge/123669, I have seen this one intermittently for a while now). I think it is simply due to a race issue in the unit test as I see no issues at all in the working code. I'll take a look at that test and see if I can make it reliable, but that work in another branch!
I think this one is ready for review again. Thanks again!
Hi Michael, thanks as always for your review. Indeed, the first failure is a trivial case related to my other branch lp:~gary-lasker/software-center/recommender-test-fix. That branch contained a change to a method name (to make its purpose more clear), and as it had not yet been merged to trunk yet my new test still used the previous method name. I merged trunk and fixed this line and the test works again now.
I also added comments to both places where I make implicit_feedback calls to the recommender service.
Finally, the second failure above (test_recommend ed_for_ you_spinner_ display) is unrelated to any changes that I have made, and as I mentioned in https:/ /code.launchpad .net/~gary- lasker/ software- center/ recommender- test-fix/ +merge/ 123669, I have seen this one intermittently for a while now). I think it is simply due to a race issue in the unit test as I see no issues at all in the working code. I'll take a look at that test and see if I can make it reliable, but that work in another branch!
I think this one is ready for review again. Thanks again!