lp:~gary-lasker/software-center/recommended-installed-feedback

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:software-center at revision 3153

Michael Vogt: Approve on 2012-09-06

Diff: 942 lines (+356/-133)

11 files modified

softwarecenter/backend/piston/sreclient_pristine.py (+1/-1)
softwarecenter/backend/recagent.py (+26/-1)
softwarecenter/enums.py (+4/-0)
softwarecenter/ui/gtk3/panes/availablepane.py (+3/-10)
softwarecenter/ui/gtk3/views/appdetailsview.py (+7/-7)
softwarecenter/ui/gtk3/views/catview_gtk.py (+59/-39)
softwarecenter/ui/gtk3/widgets/containers.py (+41/-17)
softwarecenter/ui/gtk3/widgets/recommendations.py (+79/-29)
tests/gtk3/test_catview.py (+117/-21)
tests/gtk3/windows.py (+9/-8)
tests/test_recagent.py (+10/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #944060: Provide a way for tracking if user acted on a recommendation	Medium	Fix Committed
Bug #1044107: Feature Freeze Exception: Recommender feedback (no UI change)	Medium	Fix Released

Link a bug report

Related blueprints

3107. By Gary Lasker on 2012-09-06

merge with trunk, don't wanna cruft

3106. By Gary Lasker on 2012-09-06

make a docstring more better per review comment

3105. By Gary Lasker on 2012-09-06

move the application-activated signal into the TileGrid subclass where it belongs

3104. By Gary Lasker on 2012-09-05

clean up get_test_window_recommendations in windows.py per the new factoring

3103. By Gary Lasker on 2012-09-05

merge with trunk

3102. By Gary Lasker on 2012-09-05

pep8 fixes

3101. By Gary Lasker on 2012-09-05

don't use hasattr in the FramedHeaderBox so that we can attach listeners to the more button when we need to, connect listeners for this, add a signal to the RecommenderPanelCategory (and subclass RecommenderPanelLobby) so that we can get their correct categories when clicking 'More' in those

3100. By Gary Lasker on 2012-09-05

REFACTOR: remove all need for the catview in the recommendations code

3099. By Gary Lasker on 2012-09-05

REFACTOR: make a new TileGrid subclass of FlowableGrid so that FlowableGrid remains generic, wire up the TileGrid for the various panels that it is used

3098. By Gary Lasker on 2012-09-04

GREEN: essential refactor complete and signals wired up, all test cases now working; removed the unused (with FIXME) 'application-selected' signal from catview as it is not used there (we only 'activate' apps from this widget), fix single-line cut-and-paste error in the test case