Merge lp:~gary-lasker/software-center/recommendations-sso-login-lp967064 into lp:software-center

Proposed by Gary Lasker on 2012-04-16
Status: Merged
Merge reported by: Gary Lasker
Merged at revision: not available
Proposed branch: lp:~gary-lasker/software-center/recommendations-sso-login-lp967064
Merge into: lp:software-center
Diff against target: 12 lines (+1/-1)
1 file modified
softwarecenter/ui/gtk3/widgets/recommendations.py (+1/-1)
To merge this branch: bzr merge lp:~gary-lasker/software-center/recommendations-sso-login-lp967064
Reviewer Review Type Date Requested Status
software-store-developers 2012-04-16 Pending
Review via email: mp+102046@code.launchpad.net

Description of the change

This branch implements the remaining part of the fix for bug 967064, that is, it modifies the opt-in text to remove the word "anonymous" as we always require sign-in to Ubuntu SSO when opting in to recommendations.

NOTE 1: This branch requires lp:~gary-lasker/software-center/recommendations-sso-login-lp973612 to be merged first, as that branch implements the functional changes required for the bug.

NOTE 2: This branch will require a String Freeze Exception!!!

Many thanks for your review!!

To post a comment you must log in.
Michael Vogt (mvo) wrote :

Thanks for this branch. I set this back to "work-in-progress" as it needs a UI freeze exception and coordination with the SRU team/langpack update team first. Once that is done I'm happy to merge the branch.

Michael Vogt (mvo) wrote :

Once the UI freeze exception bugreport is filed please link it to this branch (or feel free to reuse the bug #967064, but that has currently a slightly different content so a new bug might be better).

2979. By Gary Lasker on 2012-04-18

merged lp:~gary-lasker/software-center/recommendations-sso-login-lp973612 for latest updates

2980. By Gary Lasker on 2012-04-21

merge with trunk

Gary Lasker (gary-lasker) wrote :

The UI Freeze exception is filed and both the ubuntu-translators and ubuntu-docs teams have been notified. The exception bug is bug 986437. Thanks again!

Gary Lasker (gary-lasker) wrote :

As we now have a separate bug for the string freeze exception (bug 986437), the other parts of this bug fix can be considered complete and have been merged. I'll set the status of this MP accordingly, and will file a separate one for the string freeze exception branch at lp:~gary-lasker/software-center/recommendations-string-change-lp986437.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'softwarecenter/ui/gtk3/widgets/recommendations.py'
--- softwarecenter/ui/gtk3/widgets/recommendations.py 2012-04-20 09:41:25 +0000
+++ softwarecenter/ui/gtk3/widgets/recommendations.py 2012-04-21 00:53:20 +0000
@@ -146,7 +146,7 @@
146 TURN_ON_RECOMMENDATIONS_TEXT = _(u"Turn On Recommendations")146 TURN_ON_RECOMMENDATIONS_TEXT = _(u"Turn On Recommendations")
147 RECOMMENDATIONS_OPT_IN_TEXT = _(u"To make recommendations, "147 RECOMMENDATIONS_OPT_IN_TEXT = _(u"To make recommendations, "
148 "Ubuntu Software Center "148 "Ubuntu Software Center "
149 "will occasionally send to Canonical an anonymous list "149 "will occasionally send to Canonical a list "
150 "of software currently installed.")150 "of software currently installed.")
151151
152 def __init__(self, catview):152 def __init__(self, catview):

Subscribers

People subscribed via source and target branches