Code review comment for lp:~gary-lasker/software-center/previous-purchase-sorting-lp873104

Michael Vogt (mvo) wrote :

Thanks for your branch.

This is great work and a nice improvement, especially that the special case got removed is great.

The change:
29 + self.state.search_term = ""
make me a little bit nervous as the _clear_search() is called in various places, but I could not
think of (or find one by playing around) any regression this might cause so I think its fine.

Unfortunately bug #969273 is only fixed inside the "Previous purchases" subcategory (which is nice),
but its not fixed in the "All software" case which Michael Terry was referring to in the bugreport.
I updated the description there to make the testcase clearer. For me it still returns
three items with this branch. But that is not a regression or anything like this, so I'm happy to
merge the branch as #873104 is fixed.

review: Approve

« Back to merge proposal