lp:~gary-lasker/software-center/offline-opt-in-lp965397-for-quantal

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:software-center at revision 3074

Michael Vogt: Approve on 2012-07-27

Diff: 356 lines (+138/-90)

3 files modified

softwarecenter/backend/recagent.py (+17/-1)
softwarecenter/ui/gtk3/widgets/recommendations.py (+56/-26)
tests/gtk3/test_catview.py (+65/-63)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #965397: Poor behavior of recommendations if you're offline when you opt in

Medium

Fix Released

Link a bug report

Related blueprints

3080. By Gary Lasker on 2012-07-31

more minor test cleanup per review comments from mvo

3079. By Gary Lasker on 2012-07-31

refactor test_catview so that the patch decorators needed for the recommendations tests are isolated to those tests

3078. By Gary Lasker on 2012-07-31

use config's getboolean to simplify the recommender_opt_in_requested code

3077. By Gary Lasker on 2012-07-26

enable two currently disabled recommender unit tests as they are working for me, move the patch decorators up to the base class setup method and make corresponding changes to the individual tests, add unit test for the network unavailable condition per the bug, disable test_new_no_sort_info_yet as it seems to be not working at the moment

3076. By Gary Lasker on 2012-07-26

functionality working

3075. By Gary Lasker on 2012-07-26

clean up some old bad code, return boolean for recommendations opt-in requested, resolve conflicts

3074. By Gary Lasker on 2012-07-26

we'll want to reset a pending opt-in request when an opt-out occurs

3073. By Gary Lasker on 2012-07-26

implement basic UI, persist the request to opt-in if it is made when offline and automatically load the the recommendations on next restart when network access is available

3072. By Michael Vogt on 2012-07-20

releasing version 5.3.5

3071. By Michael Vogt on 2012-07-19

merged from the 5.2 branch, resolve conflicts (many :/) and fix failing tests in test_unity_launcher_integration via setUpClass and updates to the DesktopFilepathConversionTestCase bits to use os.path.join()