Merge lp:~gary-lasker/software-center/launcher-integration-unit-tests into lp:software-center/5.2
Status: | Merged |
---|---|
Merged at revision: | 3064 |
Proposed branch: | lp:~gary-lasker/software-center/launcher-integration-unit-tests |
Merge into: | lp:software-center/5.2 |
Prerequisite: | lp:~gary-lasker/software-center/tech-items-to-launcher-fix-lp1006483 |
Diff against target: | 0 lines |
To merge this branch: | bzr merge lp:~gary-lasker/software-center/launcher-integration-unit-tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Vogt | Approve | ||
Review via email: mp+115236@code.launchpad.net |
Commit message
* lp:~gary-lasker/software-center/launcher-integration-unit-tests:
- additional unit tests to round out the suite for the Unity
launcher integration feature
Description of the change
This branch adds new unit tests for improved coverage of the Software Center side of the Unity launcher integration feature. First, it adds support for testing that the launcher add occurs on the "transaction-
1. A fully displayable application (the launcher call is made)
2. An application whose desktop file specifies "NoDisplay=true (the launcher call is *not* made)
3. An application whose desktop file does not specify an "Exec" entry (the launcher call is *not* made)
As noted, the prerequisite for the tests are the branch:
lp:~gary-lasker/software-center/tech-items-to-launcher-fix-lp1006483
Thanks for your review!
Thanks, this looks good and its good that the tests are working with the new functionality and extended to cover the additional testcases.
Some suggestions for refactor:
* _navigate_ to_appdetails_ and_install and _install_ from_list_ view look pretty similar at the end, the common code should probably go into a single function to avoid duplication
* pyflakes has some comments that needs adressing before this can land
* I don't think that _fake_send_ application_ to_launcher_ and_check is actually called in test_unity_ launcher_ integration_ disabled, test_unity_ launcher_ integration_ details_ view or test_unity_ launcher_ integration_ list_view. I added a invalid line in it ("xxx") and a print
and none of this appears to be executed. Please have a look at this, I suspect you just need
to use patch.object() here as the available_pane is already created when the function runs.