Merge lp:~gary-lasker/software-center/keep-add-to-launcher-offer-lp765389 into lp:software-center
Status: | Merged |
---|---|
Merged at revision: | 1743 |
Proposed branch: | lp:~gary-lasker/software-center/keep-add-to-launcher-offer-lp765389 |
Merge into: | lp:software-center |
Diff against target: |
178 lines (+72/-38) 2 files modified
debian/changelog (+9/-0) softwarecenter/view/softwarepane.py (+63/-38) |
To merge this branch: | bzr merge lp:~gary-lasker/software-center/keep-add-to-launcher-offer-lp765389 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Vogt | Pending | ||
Review via email: mp+58414@code.launchpad.net |
Description of the change
This branch keeps the offer to add an application to the launcher displayed for the full duration of the time that the details view for that application is showing. Previously, we removed the offer when the installation was complete (this was a side-effect of the earlier design, aka "plan a", but in no way is it necessary to do this). Now, if an installation has been completed, then clicking "Add to Launcher" will immediately make the dbus call to Unity and the application will appear in the launcher. If "Add to Launcher" is clicked before the installation is completed, it is simply queued and is then added after install exactly as it worked previously.
This branch continues to work for multiple simultaneous installs, queuing up launcher add requests and executing them at the end of each install, as required.
I think this fix greatly enhances the usability of the "Add to Launcher" feature, particularly in cases where an application install is extremely quick (as described in the bug report from Martin), and I think it would be very worthwhile to get this for natty. Note that I tested it pretty heavily under many different combinations of install/
Many thanks!
Thanks for this branch. I think its a important and useful fix. However the current branch fails in test_unity_ launcher_ itegration. py. I look at this next.