Code review comment for lp:~gary-lasker/software-center/fix-makedirs-race-crashes

Revision history for this message
Gary Lasker (gary-lasker) wrote :

I took a quick look at making a unit test for safe_makedirs, but I don't immediately see a way to simulate the race condition that causes the error. If you would like a test for that and have any ideas about how to simulate the condition, please let me know and I'll be happy to write the test. As I mentioned, though, I think it's a trivial enough method that a unit test for it is probably overkill.

Thanks again!

« Back to merge proposal