Code review comment for lp:~gary-lasker/software-center/fix-makedirs-race-crashes

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for the branch, it looks good, but there is a issue with the test.

I noticed that you use "os.chmod(cache_dir, 600)" here. As this is decimal 600 (and not octal) its confusing for me to read and will result in a odd permission on disk (see my comment for https://code.launchpad.net/~gary-lasker/software-center/fix-shutdown-crash-lp996333/+merge/105027). Please use either 0400 or stat.S_IRUSR.

It would be nice if safe_makedirs() would get a individual test in test_utils.py (even though its pretty trivial).

« Back to merge proposal