Code review comment for lp:~gary-lasker/software-center/fix-lp1023777-for-5.2

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for the branch and for noticing this bugreport. The original report was against quantal and there its
easy to reproduce, the bugtitle says:
 Title: software-center crashed with AttributeError in _on_show_exhibits(): 'FeaturedExhibit' object has no attribute 'click_url'

and indeed, the FeaturedExibit lacks this attribute, so adding it there via the approach below looks cleaner to me:

=== modified file 'softwarecenter/ui/gtk3/widgets/'
--- softwarecenter/ui/gtk3/widgets/ 2012-07-10 03:23:44 +0000
+++ softwarecenter/ui/gtk3/widgets/ 2012-07-13 07:13:16 +0000
@@ -93,6 +93,7 @@
             'title': _("Our star apps"),
             'subtitle': _("Come and explore our favourites"),
+ self.click_url = ""
         # we should extract this automatically from the html
         #self.atk_name = _("Default Banner")
         #self.atk_description = _("You see this banner because you have no "

to test you can use trunk or 5.2 and run:
 $ SOFTWARE_CENTER_DISTRO_CODENAME=no-real-distro ./software-center
and click on the FeaturedExhibits banner to trigger both the original bug and the fix.

As this almost caused a regression in stable I added a regression test in trunk:

Should be easy to cherry pick this to 5.2 too.

review: Needs Fixing

« Back to merge proposal