Thanks for the branch and for noticing this bugreport. The original report was against quantal and there its
easy to reproduce, the bugtitle says:
Title: software-center crashed with AttributeError in _on_show_exhibits(): 'FeaturedExhibit' object has no attribute 'click_url'
and indeed, the FeaturedExibit lacks this attribute, so adding it there via the approach below looks cleaner to me:
=== modified file 'softwarecenter/ui/gtk3/widgets/exhibits.py'
--- softwarecenter/ui/gtk3/widgets/exhibits.py 2012-07-10 03:23:44 +0000
+++ softwarecenter/ui/gtk3/widgets/exhibits.py 2012-07-13 07:13:16 +0000
@@ -93,6 +93,7 @@ 'title': _("Our star apps"), 'subtitle': _("Come and explore our favourites"),
}
+ self.click_url = ""
# we should extract this automatically from the html #self.atk_name = _("Default Banner") #self.atk_description = _("You see this banner because you have no "
to test you can use trunk or 5.2 and run:
$ SOFTWARE_CENTER_DISTRO_CODENAME=no-real-distro ./software-center
and click on the FeaturedExhibits banner to trigger both the original bug and the fix.
Thanks for the branch and for noticing this bugreport. The original report was against quantal and there its exhibits( ): 'FeaturedExhibit' object has no attribute 'click_url'
easy to reproduce, the bugtitle says:
Title: software-center crashed with AttributeError in _on_show_
and indeed, the FeaturedExibit lacks this attribute, so adding it there via the approach below looks cleaner to me:
=== modified file 'softwarecenter /ui/gtk3/ widgets/ exhibits. py' ui/gtk3/ widgets/ exhibits. py 2012-07-10 03:23:44 +0000 ui/gtk3/ widgets/ exhibits. py 2012-07-13 07:13:16 +0000
' title': _("Our star apps"),
' subtitle' : _("Come and explore our favourites"),
#self. atk_name = _("Default Banner")
#self. atk_description = _("You see this banner because you have no "
--- softwarecenter/
+++ softwarecenter/
@@ -93,6 +93,7 @@
}
+ self.click_url = ""
# we should extract this automatically from the html
to test you can use trunk or 5.2 and run: CENTER_ DISTRO_ CODENAME= no-real- distro ./software-center
$ SOFTWARE_
and click on the FeaturedExhibits banner to trigger both the original bug and the fix.
As this almost caused a regression in stable I added a regression test in trunk:
lp:~mvo/software-center/fix-lp1023777
Should be easy to cherry pick this to 5.2 too.