Merge lp:~gary-lasker/software-center/fix-crash_lp973379 into lp:software-center/5.2

[Gary Lasker]

This branch should fix intermittent crasher bug 973379 by makes sure the cache is ready before accessing the installed package list for upload to the recommender service. Since this happens asynchronously, it can occur on a cache refresh, causing the potential for the crash.

I could not find a reliable way to reproduce this error as it depends quite heavily on timing, but this should be a very low-risk change.

Thanks!

[Michael Vogt (mvo)]

Thanks for this branch, looks good. Its a bit scary that this can happen as the profile upload is timed after 45s but its probably a combination of cache-reopen after e.g. software-center-agent finished.

review: Approve

=== modified file 'softwarecenter/ui/gtk3/app.py'
--- softwarecenter/ui/gtk3/app.py	2012-05-10 17:12:20 +0000
+++ softwarecenter/ui/gtk3/app.py	2012-05-14 21:38:19 +0000
@@ -498,6 +498,7 @@
             self.menuitem_recommendations.set_label(
                                             _(u"Turn On Recommendations…"))
 
+    @wait_for_apt_cache_ready
     def _upload_recommendations_profile(self):
         recommender_agent = self._get_recommender_agent()
         if recommender_agent.is_opted_in():