Merge lp:~gary-lasker/software-center/fix-crash-lp969737 into lp:software-center

[Gary Lasker]

This branch fixes bug 969737, an intermittent crash that can occur when saving the vertical position of the installed pane treeview on a cache refresh. Side effect if the error condition occurs is minimal, the treeview is simply restored at the top of the pane. The state of the expanded nodes, etc., is retained.

Many thanks!

[Michael Vogt (mvo)]

Thanks for this fix!

review: Approve

=== modified file 'softwarecenter/ui/gtk3/panes/installedpane.py'
--- softwarecenter/ui/gtk3/panes/installedpane.py	2012-04-04 16:03:25 +0000
+++ softwarecenter/ui/gtk3/panes/installedpane.py	2012-04-06 23:41:19 +0000
@@ -332,7 +332,11 @@
         self.app_view.tree_view.map_expanded_rows(
             lambda view, path, data: expanded_rows.append(path.to_string()),
             None)
-        vadj = self.app_view.tree_view_scroll.get_vadjustment().get_value()
+        va = self.app_view.tree_view_scroll.get_vadjustment()
+        if va:
+            vadj = va.get_value()
+        else:
+            vadj = 0
         return expanded_rows, vadj
 
     def _restore_treeview_state(self, state):