Code review comment for lp:~gary-lasker/software-center/fix-crash-lp961198

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for this fix, its fine and I merged it, but I added a comment and changed:
+ recommendations_menuitem = self.builder.get_object(
+ "menuitem_recommendations")
+ recommendations_menuitem.set_sensitive(True)

to

+ self.menuitem_recommendations.set_sensitive(True)

because the SimpleGtkbuilderApp that we use will make all widgets available with their names
as attributes of the application, so the call to self.builder is not really needed (will also
do no harm)

review: Approve

« Back to merge proposal