Merge lp:~gary-lasker/software-center/fix-crash-lp951238 into lp:software-center

Proposed by Gary Lasker on 2012-03-19
Status: Merged
Merged at revision: 2891
Proposed branch: lp:~gary-lasker/software-center/fix-crash-lp951238
Merge into: lp:software-center
Diff against target: 12 lines (+2/-0)
1 file modified
softwarecenter/ui/gtk3/panes/softwarepane.py (+2/-0)
To merge this branch: bzr merge lp:~gary-lasker/software-center/fix-crash-lp951238
Reviewer Review Type Date Requested Status
software-store-developers 2012-03-19 Pending
Review via email: mp+98302@code.launchpad.net

Description of the change

Small fix for a crash that can occur if we get a refresh_apps before the app_view pane is ready. Please see the corresponding bug 951238 for details and stacktrace.

Thanks!

To post a comment you must log in.
Michael Vogt (mvo) wrote :

Thanks, this looks fine.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/panes/softwarepane.py'
2--- softwarecenter/ui/gtk3/panes/softwarepane.py 2012-03-15 00:16:03 +0000
3+++ softwarecenter/ui/gtk3/panes/softwarepane.py 2012-03-19 23:22:17 +0000
4@@ -430,6 +430,8 @@
5 if query is None:
6 query = self.get_query()
7
8+ if not self.app_view:
9+ return
10 self.app_view.clear_model()
11 self.search_aid.reset()
12 self.show_appview_spinner()

Subscribers

People subscribed via source and target branches