Merge lp:~gary-lasker/software-center/fix-crash-lp1000238 into lp:software-center
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 3007 | ||||
Proposed branch: | lp:~gary-lasker/software-center/fix-crash-lp1000238 | ||||
Merge into: | lp:software-center | ||||
Diff against target: |
13 lines (+0/-3) 1 file modified
softwarecenter/ui/gtk3/views/appdetailsview.py (+0/-3) |
||||
To merge this branch: | bzr merge lp:~gary-lasker/software-center/fix-crash-lp1000238 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Vogt | Approve | ||
Review via email: mp+106082@code.launchpad.net |
Description of the change
This branch fixes the Quantal-only crasher bug 1000238. This is a pretty bad one as it prevents startup of Software Center (the window just disappears) and it appears to affect everyone using Quantal. Luckily, there aren't very many of those folks just yet.
The fix is simple and safe; just remove an obsolete workaround for a long-ago-fixed theming bug 606942. Removing the workaround has no visible effect on the progress bars which look exactly the same whether this line of code is there or not. The original bug in light-themes (bug 606942) was fixed long ago. I've tested this in a Quetzal VM and with this fix Software Center starts up fine.
We only need this one for Quetzal so I've proposed the merge against trunk.
Thanks for your review!
Thanks, that looks fine for trunk. I wonder if we still need it for 12.04 or if we can remove it here too?