Merge lp:~gary-lasker/software-center/fix-crash-lp1000238 into lp:software-center

Proposed by Gary Lasker on 2012-05-17
Status: Merged
Merged at revision: 3007
Proposed branch: lp:~gary-lasker/software-center/fix-crash-lp1000238
Merge into: lp:software-center
Diff against target: 13 lines (+0/-3)
1 file modified
softwarecenter/ui/gtk3/views/appdetailsview.py (+0/-3)
To merge this branch: bzr merge lp:~gary-lasker/software-center/fix-crash-lp1000238
Reviewer Review Type Date Requested Status
Michael Vogt 2012-05-17 Approve on 2012-05-21
Review via email: mp+106082@code.launchpad.net

Description of the change

This branch fixes the Quantal-only crasher bug 1000238. This is a pretty bad one as it prevents startup of Software Center (the window just disappears) and it appears to affect everyone using Quantal. Luckily, there aren't very many of those folks just yet.

The fix is simple and safe; just remove an obsolete workaround for a long-ago-fixed theming bug 606942. Removing the workaround has no visible effect on the progress bars which look exactly the same whether this line of code is there or not. The original bug in light-themes (bug 606942) was fixed long ago. I've tested this in a Quetzal VM and with this fix Software Center starts up fine.

We only need this one for Quetzal so I've proposed the merge against trunk.

Thanks for your review!

To post a comment you must log in.
Michael Vogt (mvo) wrote :

Thanks, that looks fine for trunk. I wonder if we still need it for 12.04 or if we can remove it here too?

review: Approve
Gary Lasker (gary-lasker) wrote :

We don't need it for 12.04 either, so we can remove it from both. I just did not propose it for 5.2 because it is benign there (doesn't cause a crash or any ill-effect). Still, it's useless code so we should just clean it out of there too I think.

Gary Lasker (gary-lasker) wrote :

Merged to 5.2 per mvo's MP approval and comment above. This will go to Quantal trunk in the next mergeback.

Michael Vogt (mvo) wrote :

On Mon, May 21, 2012 at 05:11:18PM -0000, Gary Lasker wrote:
> We don't need it for 12.04 either, so we can remove it from both. I just did not propose it for 5.2 because it is benign there (doesn't cause a crash or any ill-effect). Still, it's useless code so we should just clean it out of there too I think.

Thanks, I would like to get it in via the next SRU, we probably
need a new 5.2.3 anyway soon as 5.2.2 has a regression according to
errors.ubuntu.com.

Cheers,
 Michael

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/views/appdetailsview.py'
2--- softwarecenter/ui/gtk3/views/appdetailsview.py 2012-05-14 03:16:07 +0000
3+++ softwarecenter/ui/gtk3/views/appdetailsview.py 2012-05-17 00:46:19 +0000
4@@ -172,9 +172,6 @@
5 "changed", self._on_combo_multiple_versions_changed)
6 self.progress = Gtk.ProgressBar()
7
8- # theme engine hint for bug #606942
9- self.progress.set_data("transparent-bg-hint", True)
10-
11 self.pkg_state = None
12
13 self.hbox.pack_start(self.installed_icon, False, False, 0)

Subscribers

People subscribed via source and target branches