Merge lp:~gary-lasker/oneconf/action-bar-tweak into lp:oneconf

Proposed by Gary Lasker
Status: Merged
Merged at revision: 153
Proposed branch: lp:~gary-lasker/oneconf/action-bar-tweak
Merge into: lp:oneconf
Diff against target: 11 lines (+1/-0)
1 file modified
oneconf/uscplugin/oneconfpane.py (+1/-0)
To merge this branch: bzr merge lp:~gary-lasker/oneconf/action-bar-tweak
Reviewer Review Type Date Requested Status
Didier Roche Approve
Review via email: mp+70052@code.launchpad.net

Description of the change

Hello didrocks!

I made the change in software-center to make the action bar hide more "surgical" so that it skips the hide *only* in the specific case where an add-to-launcher offer is showing.

However, even with that fix I noticed that the "show technical items" hangs around in the details view for a short time before it is hidden. Kinda ugly. So I took a look at oneconf and added in a tweak to hide the action bar immediately on a switch to the details view. This is exactly what we do in availablepane.py, and this tweak is just based on that.

Now, the action bar disappears at the instant the details view is shown and it looks much nicer now I think. Please take a look and merge if you agree.

Many thanks!
Gary

To post a comment you must log in.
Didier Roche (didrocks) wrote :

Looks good! And I confirm that works beautifully :)

Thanks a lot for your fix, merging in trunk right now!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'oneconf/uscplugin/oneconfpane.py'
2--- oneconf/uscplugin/oneconfpane.py 2011-07-29 17:40:54 +0000
3+++ oneconf/uscplugin/oneconfpane.py 2011-08-01 18:01:43 +0000
4@@ -352,6 +352,7 @@
5 """callback when the navigation button with id 'details' is clicked"""
6 if not pathbar.get_active():
7 return
8+ self.action_bar.clear()
9 self.toolbar.hide()
10 self.notebook.set_current_page(self.PAGE_APP_DETAILS)
11 self.searchentry.hide()

Subscribers

People subscribed via source and target branches