Merge lp:~gang65/ubuntu-ui-toolkit/ubuntu-ui-toolkit-cutreadonly into lp:ubuntu-ui-toolkit

Proposed by Bartosz Kosiorek
Status: Merged
Merged at revision: 980
Proposed branch: lp:~gang65/ubuntu-ui-toolkit/ubuntu-ui-toolkit-cutreadonly
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 14 lines (+3/-1)
1 file modified
modules/Ubuntu/Components/TextInputPopover.qml (+3/-1)
To merge this branch: bzr merge lp:~gang65/ubuntu-ui-toolkit/ubuntu-ui-toolkit-cutreadonly
Reviewer Review Type Date Requested Status
Zsombor Egri Approve
Review via email: mp+211371@code.launchpad.net

Commit message

"Cut" operation do not shows for "ReadOnly's" TextField and TextArea (LP: 1293149)

Description of the change

"Cut" operation do not shows for "ReadOnly's" TextField and TextArea (LP: 1293149)

To post a comment you must log in.
977. By Bartosz Kosiorek

"Cut" operation do not shows for "ReadOnly's" TextField and TextArea (LP: 1293149)

Revision history for this message
Zsombor Egri (zsombi) wrote :

Nice catch! Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/TextInputPopover.qml'
2--- modules/Ubuntu/Components/TextInputPopover.qml 2013-10-18 07:21:01 +0000
3+++ modules/Ubuntu/Components/TextInputPopover.qml 2014-03-17 17:20:22 +0000
4@@ -33,7 +33,9 @@
5 }
6 Action {
7 text: i18n.tr("Cut")
8- enabled: target && target.selectedText !== ""
9+ // If paste/editing is not possible, then disable also "Cut" operation
10+ // It is applicable for ReadOnly's TextFields and TextAreas
11+ enabled: target && target.selectedText !== "" && target.canPaste
12 onTriggered: target.cut()
13 }
14 Action {

Subscribers

People subscribed via source and target branches

to status/vote changes: