Merge lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-store-name-fix into lp:ubuntu-calculator-app

Proposed by Bartosz Kosiorek
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 209
Merged at revision: 209
Proposed branch: lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-store-name-fix
Merge into: lp:ubuntu-calculator-app
Diff against target: 66 lines (+11/-6)
3 files modified
CMakeLists.txt (+2/-2)
debian/changelog (+7/-2)
manifest.json.in (+2/-2)
To merge this branch: bzr merge lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-store-name-fix
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+264349@code.launchpad.net

Commit message

Fix name of the Calculator in the system

Description of the change

Fix name of the Calculator in the system

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

LGTM. Should we start to use the debian/changelog file?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2015-06-25 20:38:31 +0000
3+++ CMakeLists.txt 2015-07-09 20:49:15 +0000
4@@ -27,7 +27,7 @@
5
6 include(GNUInstallDirs)
7
8-set(APP_NAME ubuntu-calculator-app)
9+set(APP_NAME Calculator)
10 set(APP_HARDCODE ubuntu-calculator-app)
11 set(AUTOPILOT_DIR ubuntu_calculator_app)
12 set(MAIN_QML ${APP_HARDCODE}.qml)
13@@ -78,7 +78,7 @@
14 set(ICON ${ICON_FILE})
15 else(CLICK_MODE)
16 set(ICON ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CALCULATOR-APP_DIR}/${ICON_FILE})
17- set(EXEC ${APP_NAME})
18+ set(EXEC ${APP_HARDCODE})
19 configure_file(app/${APP_HARDCODE}.in
20 ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE})
21 install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE}
22
23=== modified file 'debian/changelog'
24--- debian/changelog 2015-06-25 20:38:31 +0000
25+++ debian/changelog 2015-07-09 20:49:15 +0000
26@@ -1,4 +1,4 @@
27-ubuntu-calculator-app (2.0.197) UNRELEASED; urgency=low
28+ubuntu-calculator-app (2.0.197ubuntu1) UNRELEASED; urgency=low
29
30 [ Bartosz Kosiorek ]
31 * Fixes in creating .deb package (LP: #1466518) (LP: #1466530) (LP: #1468385)
32@@ -19,7 +19,12 @@
33 [ Victor Thompson ]
34 * Change favorites translatable string (LP: #1464463)
35
36- -- Bartosz Kosiorek <gang65@poczta.onet.pl> Thu, 25 Jun 2015 19:56:42 +0200
37+ [ Bartosz Kosiorek ]
38+ * Fix calculator name in the store (LP: #1472559)
39+ * Allow add comma without number (LP: #1465979)
40+ * Fix confusing error messages (LP: #1469533)
41+
42+ -- Bartosz Kosiorek <gang65@poczta.onet.pl> Thu, 09 Jul 2015 22:41:57 +0200
43
44 ubuntu-calculator-app (2.0.182) vivid; urgency=medium
45 * Add haptic feedback to buttons
46
47=== modified file 'manifest.json.in'
48--- manifest.json.in 2015-01-26 22:56:40 +0000
49+++ manifest.json.in 2015-07-09 20:49:15 +0000
50@@ -1,6 +1,7 @@
51 {
52+ "name": "com.ubuntu.calculator",
53 "architecture": "all",
54- "description": "A calculator for Ubuntu Touch",
55+ "description": "Powerful and easy to use calculator.",
56 "framework": "ubuntu-sdk-14.10",
57 "hooks": {
58 "@APP_HARDCODE@": {
59@@ -9,7 +10,6 @@
60 }
61 },
62 "maintainer": "Ubuntu App Cats <ubuntu-touch-coreapps@lists.launchpad.net>",
63- "name": "com.ubuntu.calculator",
64 "title": "@APP_NAME@",
65 "icon": "@ICON@",
66 "version": "@APP_VERSION@.@BZR_REVNO@",

Subscribers

People subscribed via source and target branches