Merge lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-warning into lp:ubuntu-calculator-app

Proposed by Bartosz Kosiorek
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 175
Merged at revision: 179
Proposed branch: lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-warning
Merge into: lp:ubuntu-calculator-app
Diff against target: 58 lines (+7/-6)
2 files modified
po/com.ubuntu.calculator.pot (+4/-4)
tests/autopilot/ubuntu_calculator_app/tests/__init__.py (+3/-2)
To merge this branch: bzr merge lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-fix-autopilot-warning
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Riccardo Padovani Approve
Review via email: mp+257859@code.launchpad.net

Commit message

Use fixtures.EnvironmentVariable instead of patch_environment, which
    is deprecated.

Description of the change

Use fixtures.EnvironmentVariable instead of patch_environment, which
    is deprecated.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
174. By Bartosz Kosiorek

Update translation

175. By Bartosz Kosiorek

Sync with trunk

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

lgtm, thanks

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/com.ubuntu.calculator.pot'
2--- po/com.ubuntu.calculator.pot 2015-04-30 06:59:48 +0000
3+++ po/com.ubuntu.calculator.pot 2015-04-30 09:31:42 +0000
4@@ -8,7 +8,7 @@
5 msgstr ""
6 "Project-Id-Version: \n"
7 "Report-Msgid-Bugs-To: \n"
8-"POT-Creation-Date: 2015-04-30 08:58+0200\n"
9+"POT-Creation-Date: 2015-04-30 11:30+0200\n"
10 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
11 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
12 "Language-Team: LANGUAGE <LL@li.org>\n"
13@@ -101,14 +101,14 @@
14 msgid "Yesterday"
15 msgstr ""
16
17-#: /tmp/tmp.qLTfJqU5Ys/po/ubuntu-calculator-app.desktop.in.in.h:1
18+#: /tmp/tmp.esBHnyUxUN/po/ubuntu-calculator-app.desktop.in.in.h:1
19 msgid "Calculator"
20 msgstr ""
21
22-#: /tmp/tmp.qLTfJqU5Ys/po/ubuntu-calculator-app.desktop.in.in.h:2
23+#: /tmp/tmp.esBHnyUxUN/po/ubuntu-calculator-app.desktop.in.in.h:2
24 msgid "A calculator for Ubuntu."
25 msgstr ""
26
27-#: /tmp/tmp.qLTfJqU5Ys/po/ubuntu-calculator-app.desktop.in.in.h:3
28+#: /tmp/tmp.esBHnyUxUN/po/ubuntu-calculator-app.desktop.in.in.h:3
29 msgid "math;addition;subtraction;multiplication;division;"
30 msgstr ""
31
32=== modified file 'tests/autopilot/ubuntu_calculator_app/tests/__init__.py'
33--- tests/autopilot/ubuntu_calculator_app/tests/__init__.py 2015-04-14 19:17:35 +0000
34+++ tests/autopilot/ubuntu_calculator_app/tests/__init__.py 2015-04-30 09:31:42 +0000
35@@ -1,6 +1,6 @@
36 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
37 #
38-# Copyright (C) 2013, 2014 Canonical Ltd
39+# Copyright (C) 2013-2015 Canonical Ltd
40 #
41 # This program is free software: you can redistribute it and/or modify
42 # it under the terms of the GNU General Public License version 3 as
43@@ -19,6 +19,7 @@
44 import os
45 import shutil
46 import logging
47+import fixtures
48
49 import ubuntu_calculator_app
50
51@@ -65,7 +66,7 @@
52 # Unset the current locale to ensure locale-specific data
53 # (day and month names, first day of the week, …) doesn’t get
54 # in the way of test expectations.
55- self.patch_environment('LC_ALL', 'C')
56+ self.useFixture(fixtures.EnvironmentVariable('LC_ALL', 'C'))
57 self.app = ubuntu_calculator_app.CalculatorApp(self.launcher(),
58 self.test_type)
59

Subscribers

People subscribed via source and target branches