Merge lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-display-fix into lp:ubuntu-calculator-app

Proposed by Bartosz Kosiorek
Status: Merged
Approved by: Niklas Wenzel
Approved revision: 191
Merged at revision: 192
Proposed branch: lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-display-fix
Merge into: lp:ubuntu-calculator-app
Diff against target: 136 lines (+21/-18)
2 files modified
app/ubuntu-calculator-app.qml (+3/-0)
po/com.ubuntu.calculator.pot (+18/-18)
To merge this branch: bzr merge lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-display-fix
Reviewer Review Type Date Requested Status
Niklas Wenzel (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+262268@code.launchpad.net

Commit message

Fix display issue

Description of the change

Fix display issue

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Works fine, thanks. :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/ubuntu-calculator-app.qml'
2--- app/ubuntu-calculator-app.qml 2015-06-11 15:40:14 +0000
3+++ app/ubuntu-calculator-app.qml 2015-06-17 20:18:25 +0000
4@@ -78,6 +78,7 @@
5 * place the result in right vars
6 */
7 function deleteLastFormulaElement() {
8+ isFormulaIsValidToCalculate = false;
9 if (textInputField.cursorPosition === textInputField.length) {
10 longFormula = Formula.deleteLastFormulaElement(isLastCalculate, longFormula)
11 } else {
12@@ -96,6 +97,7 @@
13 * Function to clear formula in input text field
14 */
15 function clearFormula() {
16+ isFormulaIsValidToCalculate = false;
17 shortFormula = "";
18 longFormula = "";
19 displayedInputText = "";
20@@ -135,6 +137,7 @@
21 // If the user press a number after the press of "=" we start a new
22 // formula, otherwise we continue with the old one
23 if (!isNaN(visual) && isLastCalculate) {
24+ isFormulaIsValidToCalculate = false;
25 longFormula = displayedInputText = shortFormula = "";
26 }
27 isLastCalculate = false;
28
29=== modified file 'po/com.ubuntu.calculator.pot'
30--- po/com.ubuntu.calculator.pot 2015-06-12 01:55:49 +0000
31+++ po/com.ubuntu.calculator.pot 2015-06-17 20:18:25 +0000
32@@ -8,7 +8,7 @@
33 msgstr ""
34 "Project-Id-Version: \n"
35 "Report-Msgid-Bugs-To: \n"
36-"POT-Creation-Date: 2015-06-11 20:53-0500\n"
37+"POT-Creation-Date: 2015-06-17 22:10+0200\n"
38 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
39 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
40 "Language-Team: LANGUAGE <LL@li.org>\n"
41@@ -21,35 +21,35 @@
42 msgid "NaN"
43 msgstr ""
44
45-#: ../app/ubuntu-calculator-app.qml:252 ../app/ubuntu-calculator-app.qml:257
46+#: ../app/ubuntu-calculator-app.qml:255 ../app/ubuntu-calculator-app.qml:260
47 msgid "Favorite"
48 msgstr ""
49
50-#: ../app/ubuntu-calculator-app.qml:310
51+#: ../app/ubuntu-calculator-app.qml:313
52 msgid "Cancel"
53 msgstr ""
54
55-#: ../app/ubuntu-calculator-app.qml:324
56+#: ../app/ubuntu-calculator-app.qml:327
57 msgid "Select All"
58 msgstr ""
59
60-#: ../app/ubuntu-calculator-app.qml:324
61+#: ../app/ubuntu-calculator-app.qml:327
62 msgid "Select None"
63 msgstr ""
64
65-#: ../app/ubuntu-calculator-app.qml:331 ../app/ubuntu-calculator-app.qml:402
66+#: ../app/ubuntu-calculator-app.qml:334 ../app/ubuntu-calculator-app.qml:405
67 msgid "Copy"
68 msgstr ""
69
70-#: ../app/ubuntu-calculator-app.qml:339 ../app/ubuntu-calculator-app.qml:454
71+#: ../app/ubuntu-calculator-app.qml:342 ../app/ubuntu-calculator-app.qml:457
72 msgid "Delete"
73 msgstr ""
74
75-#: ../app/ubuntu-calculator-app.qml:415
76+#: ../app/ubuntu-calculator-app.qml:418
77 msgid "Edit"
78 msgstr ""
79
80-#: ../app/ubuntu-calculator-app.qml:431
81+#: ../app/ubuntu-calculator-app.qml:434
82 msgid "Add to favorites"
83 msgstr ""
84
85@@ -59,8 +59,8 @@
86 #. TRANSLATORS: this is a time formatting string, see
87 #. http://qt-project.org/doc/qt-5/qml-qtqml-date.html#details for valid
88 #. expressions
89-#: ../app/ubuntu-calculator-app.qml:585 ../app/ui/FavouritePage.qml:89
90-#: ../app/ui/Screen.qml:50
91+#: ../app/ubuntu-calculator-app.qml:588 ../app/ui/FavouritePage.qml:89
92+#: ../app/ui/Screen.qml:51
93 msgid "dd MMM yyyy"
94 msgstr ""
95
96@@ -82,33 +82,33 @@
97 msgid "mod"
98 msgstr ""
99
100-#: ../app/ui/Screen.qml:36
101+#: ../app/ui/Screen.qml:37
102 msgid "Just now"
103 msgstr ""
104
105-#: ../app/ui/Screen.qml:38
106+#: ../app/ui/Screen.qml:39
107 msgid "Today "
108 msgstr ""
109
110 #. TRANSLATORS: this is a time formatting string, see
111 #. http://qt-project.org/doc/qt-5/qml-qtqml-date.html#details for
112 #. valid expressions
113-#: ../app/ui/Screen.qml:42
114+#: ../app/ui/Screen.qml:43
115 msgid "hh:mm"
116 msgstr ""
117
118-#: ../app/ui/Screen.qml:44
119+#: ../app/ui/Screen.qml:45
120 msgid "Yesterday"
121 msgstr ""
122
123-#: /tmp/tmp.esBHnyUxUN/po/ubuntu-calculator-app.desktop.in.in.h:1
124+#: /tmp/tmp.9RSzhUvMx8/po/ubuntu-calculator-app.desktop.in.in.h:1
125 msgid "Calculator"
126 msgstr ""
127
128-#: /tmp/tmp.esBHnyUxUN/po/ubuntu-calculator-app.desktop.in.in.h:2
129+#: /tmp/tmp.9RSzhUvMx8/po/ubuntu-calculator-app.desktop.in.in.h:2
130 msgid "A calculator for Ubuntu."
131 msgstr ""
132
133-#: /tmp/tmp.esBHnyUxUN/po/ubuntu-calculator-app.desktop.in.in.h:3
134+#: /tmp/tmp.9RSzhUvMx8/po/ubuntu-calculator-app.desktop.in.in.h:3
135 msgid "math;addition;subtraction;multiplication;division;"
136 msgstr ""

Subscribers

People subscribed via source and target branches