Merge lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-copypaste into lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

[Bartosz Kosiorek]

Support select, copy and paste of calculator numbers

Support select, copy and paste of calculator numbers.

You could use mouse selection, double click, CTRL+C, CTRL+V.

If you hold mouse/finger longer on number, the menu will appear, and you would have possibility to select and copy

I have tested it on Desktop and it works perfectly.
Please test it on Smartphone and tablet.

[lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-copypaste]

234. By Bartosz Kosiorek on 2014-03-13

Implement selection/copy/paste feature for numbers and labels

[Mihir Soni (mihirsoni)]

Hi Bartosz ,

Thanks a lot for your MR.

There are couple of suggestions:

1.Could you please remove the cursor (Edit cursor, it misguide to user in calculator)
2.I tried to paste back to the field, it is not working though (If any specific steps , let us know.)
3.Cut operation is not performing , if not required could you please remove the Cut operation.

We need to ask team,for using textbox instead of Labels, i guess it shouldn't be any issue though.

review: Needs Fixing

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Tried on device. When I hold down on a number I get a dialog which says "Select All" or "Select word" If I choose either, another box pops up with "Cut" and "Copy" in, but it then immediately disappears.

http://popey.com/~alan/phablet/device-2014-03-14-103530.png

I couldn't get a screenshot of the cut/copy dialog because it appears too quickly.

[Bartosz Kosiorek (gang65)]

So we have several issues:
1. Could you please remove the cursor (Edit cursor, it misguide to user in calculator)
   Unfortunately TextField doesn't have option to disable cursor. cursorVisible property disable it only for active focus. I could try once again with cursorDelegate
2. I tried to paste back to the field, it is not working though.
   It is another feature. It will be tricky to implement it. All TextFields are read only, so we could only select it and copy.
3.Cut operation is not performing , if not required could you please remove the Cut operation?
   Very good question. There is no option to remove "Cut operation". Because the TextFields are ReadOnly, there shouldn't be any "Cut" option. This bug should be submitted to Ubuntu SDK
4. Box pops up with "Cut" and "Copy" in, but it then immediately disappears.
   I tested with ubuntu-docviewer-app (on desktop) and it works in the same way.
   This bug should be submitted to Ubuntu SDK with critical priority.

Do you know how to submit errors on Ubuntu SDK? Fourth issue is critical one, and without fix, the copy is not working for other Ubuntu appliacations also.

[Bartosz Kosiorek (gang65)]

review: Needs Information

[Bartosz Kosiorek (gang65)]

Source code of the TextField submodule is available at:
http://download.qt-project.org/official_releases/qt/5.2/5.2.1/submodules/qtquickcontrols-opensource-src-5.2.1.7z
http://download.qt-project.org/official_releases/qt/5.2/5.2.1/submodules/

review: Needs Information

[Riccardo Padovani (rpadovani)]

Bartosz, you can open bug against ubuntu sdk here: https://bugs.launchpad.net/ubuntu-ui-toolkit

I'm not sure that use TextField in place of a label is a good idea, I have to think about possible consequences

[Bartosz Kosiorek (gang65)]

> Tried on device. When I hold down on a number I get a dialog which says
> "Select All" or "Select word" If I choose either, another box pops up with
> "Cut" and "Copy" in, but it then immediately disappears.
>
> http://popey.com/~alan/phablet/device-2014-03-14-103530.png
>
> I couldn't get a screenshot of the cut/copy dialog because it appears too
> quickly.

Ploblem with disappears Cut/Copy was already registered:
https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1130369

[Bartosz Kosiorek (gang65)]

I think TextField is optimal for numbers purposes.
When Copy/Paste will be implemented by using TextFields, I would like to implement "Paste" to ubuntu-calculator-app.
So you could take same number from external source and paste it directly into calculator.

I would like to implement also some "correcting".
For example: You could long click on previos result and select "Edit" and edit previous calculations/numbers.

What do you think about that ideas?

[lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-copypaste]

235. By Bartosz Kosiorek on 2014-03-25

rebase from trunk

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:235
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/174/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1885
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-raring-amd64-ci/173
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-saucy-amd64-ci/173
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-trusty-amd64-ci/45

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/174/rebuild

review: Needs Fixing (continuous-integration)

[Bartosz Kosiorek (gang65)]

Can we merge copy/paste feature into trunk?

[Bartosz Kosiorek (gang65)]

review: Approve

[Mihir Soni (mihirsoni)]

Could you merge from latest trunk again ?

[lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-copypaste]

236. By Bartosz Kosiorek on 2014-04-26

Merge from trunk

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:236
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/183/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2231
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-raring-amd64-ci/182
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-saucy-amd64-ci/182
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-trusty-amd64-ci/54

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/183/rebuild

review: Needs Fixing (continuous-integration)

[Bartosz Kosiorek (gang65)]

It seems that there is a problem when you select title label (TextField), and then switch to formulaLabel.
The virtual keyboard doesn't appears.

[lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-copypaste]

237. By Bartosz Kosiorek on 2014-04-26

Fix hiding keyboard, when you select formula

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:237
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/184/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2232
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-raring-amd64-ci/183
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-saucy-amd64-ci/183
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calculator-app-trusty-amd64-ci/55

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calculator-app-ci/184/rebuild

review: Approve (continuous-integration)

[David Planella (dpm)]

Mihir, Riccardo, are you happy with the latest changes from Bartosz? Can we merge it?

[Alan Pope 🍺🐧🐱 🦄 (popey)]

On desktop I tried this and when I long press a result I get a popup "Select all / Select None", and after choosing "Select All" a "Copy" dialog briefly pops up. Long pressing again brings the "Copy" dialog again.

[Mihir Soni (mihirsoni)]

Looks good to me :)

Thank you.

review: Approve

=== modified file 'Simple/CalcLabel.qml'
--- Simple/CalcLabel.qml	2014-03-03 11:40:38 +0000
+++ Simple/CalcLabel.qml	2014-04-26 15:30:46 +0000
@@ -25,7 +25,7 @@
     width: parent.width
     height: row.height
 
-    property int operationsWidth: operatorLabel.width+formulaLabel.width
+    property int operationsWidth: operatorLabel.width + formulaTextField.width
     property string operation: ""
     property string numbers: ""
     property bool labelReadOnly: false
@@ -39,14 +39,14 @@
         propagateComposedEvents: true
     }
 
-    Row{
+    Row {
         id: row
         height: numbersHeight
         width: parent.width
         anchors.left: parent.left
 
         Item {
-            width: row.width - operatorLabel.width - formulaLabel.width
+            width: row.width - operatorLabel.width - formulaTextField.width
             height: parent.height
 
             TextField {
@@ -103,19 +103,34 @@
             color: "#FEFEFE"
             text: root.operation
         }
-        Label {
-            id: formulaLabel
+
+        TextField {
+            id: formulaTextField
 
             // this property is used by autopilot tests to find the correct item
             // FIXME: implement it in a better way
             property bool isLast: root.isLast
 
-            objectName: "formulaLabel"
+            objectName: "formulaTextField"
+            readOnly: true
+            selectByMouse: true
+            hasClearButton: false
             width: parent.width / 1.5
             color: numbersColor
+            // removes ubuntu shape
+            style: TextFieldStyle {
+                background: Item {}
+            }
+            
+            //If formula clicked, then hide keyboard
+            onActiveFocusChanged: {
+                if (!numberName.activeFocus) {
+                    labelVisible = false
+                }
+            }
             anchors.bottom: parent.bottom
             font.pixelSize: numbersHeight
-            fontSizeMode: Text.Fit
+
             horizontalAlignment: Text.AlignRight
             // If is a new calculation or if last calculation as been deleted print 0, else the number
             text: ((isLast && !newCalculation) || (root.numbers === "" && formulaView.headerItem.state !== "newPush")) ? "0" : root.numbers

=== modified file 'debian/changelog'
--- debian/changelog	2014-03-10 10:12:24 +0000
+++ debian/changelog	2014-04-26 15:30:46 +0000
@@ -1,5 +1,11 @@
 ubuntu-calculator-app (0.1.3ubuntu3) UNRELEASED; urgency=medium
 
+  [ Bartosz Kosiorek ]
+  * Support select, copy and paste of calculator numbers (LP: #1267821)
+  * Add possibility to correct values by pressing backspace (LP: #1286650)
+  * Allow input decimals without a numeric value at start (LP: #1273637)
+  * Fix calculate value after using CLEAR (LP: #1286932)
+
   [ Sergio Schvezov ]
   * Adding cmake