Merge lp:~gang65/mines/additional-sizes into lp:mines

Proposed by Bartosz Kosiorek
Status: Needs review
Proposed branch: lp:~gang65/mines/additional-sizes
Merge into: lp:mines
Diff against target: 47 lines (+13/-4)
1 file modified
main.qml (+13/-4)
To merge this branch: bzr merge lp:~gang65/mines/additional-sizes
Reviewer Review Type Date Requested Status
Robert Ancell Disapprove
Review via email: mp+303207@code.launchpad.net

Commit message

Add medium size of he board

Description of the change

Add medium size of he board

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

This doesn't just add a new size - it changes all the sizes...

review: Disapprove

Unmerged revisions

79. By Bartosz Kosiorek

Add new size of the board

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'main.qml'
2--- main.qml 2016-01-03 07:32:56 +0000
3+++ main.qml 2016-08-18 00:54:47 +0000
4@@ -155,7 +155,7 @@
5
6 Item {
7 anchors.fill: parent
8- anchors.margins: units.gu (2)
9+ anchors.margins: units.gu (1)
10 MineGrid {
11 id: minefield
12 anchors.horizontalCenter: parent.horizontalCenter
13@@ -243,6 +243,9 @@
14 case "small":
15 // TRANSLATORS: Setting name for small minefield
16 return i18n.tr ("Small")
17+ case "medium":
18+ // TRANSLATORS: Setting name for medium minefield
19+ return i18n.tr ("Medium")
20 case "large":
21 // TRANSLATORS: Setting name for large minefield
22 return i18n.tr ("Large")
23@@ -266,15 +269,21 @@
24 id: field_size_model
25 ListElement {
26 name: "small"
27+ grid_width: 6
28+ grid_height: 10
29+ n_mines: 10
30+ }
31+ ListElement {
32+ name: "medium"
33 grid_width: 8
34- grid_height: 8
35- n_mines: 10
36+ grid_height: 12
37+ n_mines: 18
38 }
39 ListElement {
40 name: "large"
41 grid_width: 10
42 grid_height: 16
43- n_mines: 25
44+ n_mines: 35
45 }
46 }
47 }

Subscribers

People subscribed via source and target branches