Merge lp:~gang65/messaging-app/messaging-app-chevron-down into lp:messaging-app

Proposed by Bartosz Kosiorek
Status: Needs review
Proposed branch: lp:~gang65/messaging-app/messaging-app-chevron-down
Merge into: lp:messaging-app
Diff against target: 51 lines (+6/-6)
1 file modified
src/qml/Messages.qml (+6/-6)
To merge this branch: bzr merge lp:~gang65/messaging-app/messaging-app-chevron-down
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+284544@code.launchpad.net

Commit message

Use chevron pointing down for bottom edge header (lp: #1432696)

Description of the change

Use chevron pointing down for bottom edge header (lp: #1432696)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

486. By Bartosz Kosiorek

Use chevron pointing down by bottom edge header.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/Messages.qml'
2--- src/qml/Messages.qml 2015-12-07 17:55:17 +0000
3+++ src/qml/Messages.qml 2016-01-31 22:25:49 +0000
4@@ -810,9 +810,9 @@
5 }
6
7 Action {
8- id: backButton
9+ id: downButton
10 objectName: "backButton"
11- iconName: "back"
12+ iconName: "down"
13 onTriggered: {
14 if (typeof mainPage !== 'undefined') {
15 mainPage.temporaryProperties = null
16@@ -858,7 +858,7 @@
17 head: messages.head
18 when: groupChat
19 contents: header
20- backAction: backButton
21+ backAction: downButton
22
23 actions: [
24 Action {
25@@ -872,7 +872,7 @@
26 name: "unknownContact"
27 head: messages.head
28 when: participants.length == 1 && contactWatcher.isUnknown
29- backAction: backButton
30+ backAction: downButton
31 contents: header
32
33 actions: [
34@@ -904,7 +904,7 @@
35 name: "newMessage"
36 head: messages.head
37 when: participants.length === 0 && isReady
38- backAction: backButton
39+ backAction: downButton
40 actions: [
41 Action {
42 objectName: "contactList"
43@@ -932,7 +932,7 @@
44 name: "knownContact"
45 head: messages.head
46 when: participants.length == 1 && !contactWatcher.isUnknown
47- backAction: backButton
48+ backAction: downButton
49 contents: header
50 actions: [
51 Action {

Subscribers

People subscribed via source and target branches