Merge lp:~gandelman-a/ubuntu/precise/keystone/lp945299 into lp:~ubuntu-server-dev/keystone/essex

Proposed by Adam Gandelman
Status: Merged
Merged at revision: 96
Proposed branch: lp:~gandelman-a/ubuntu/precise/keystone/lp945299
Merge into: lp:~ubuntu-server-dev/keystone/essex
Diff against target: 42 lines (+12/-6)
2 files modified
debian/changelog (+6/-0)
debian/keystone.preinst (+6/-6)
To merge this branch: bzr merge lp:~gandelman-a/ubuntu/precise/keystone/lp945299
Reviewer Review Type Date Requested Status
Dave Walker (community) Approve
Review via email: mp+95714@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dave Walker (davewalker) wrote :

Good catch!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-03-02 15:15:20 +0000
3+++ debian/changelog 2012-03-03 01:43:17 +0000
4@@ -1,3 +1,9 @@
5+keystone (2012.1~e4-0ubuntu2) precise; urgency=low
6+
7+ * debian/keystone.preinst: Create group before creating user (LP: #945299)
8+
9+ -- Adam Gandelman <adamg@canonical.com> Fri, 02 Mar 2012 17:38:00 -0800
10+
11 keystone (2012.1~e4-0ubuntu1) precise; urgency=low
12
13 [ Chuck Short ]
14
15=== modified file 'debian/keystone.preinst'
16--- debian/keystone.preinst 2012-03-01 14:30:00 +0000
17+++ debian/keystone.preinst 2012-03-03 01:43:17 +0000
18@@ -10,6 +10,12 @@
19
20 case "$1" in
21 install|upgrade)
22+ # create the keystone group
23+ if ! getent group keystone > /dev/null 2>&1
24+ then
25+ addgroup --system keystone >/dev/null || true
26+ fi
27+
28 # create the keystone user to avoid running keystone as root
29 if ! getent passwd keystone > /dev/null 2>&1
30 then
31@@ -27,12 +33,6 @@
32 usermod -g keystone keystone
33 fi
34
35- # create the keystone group
36- if ! getent group keystone > /dev/null 2>&1
37- then
38- addgroup --system keystone >/dev/null || true
39- fi
40-
41 # create appropriate directories
42 mkdir -p /var/lib/keystone/ /etc/keystone/ /var/log/keystone/
43

Subscribers

People subscribed via source and target branches