Merge lp:~gandelman-a/ubuntu/oneiric/glance/lp784837 into lp:ubuntu/oneiric/glance

Proposed by Adam Gandelman
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp:~gandelman-a/ubuntu/oneiric/glance/lp784837
Merge into: lp:ubuntu/oneiric/glance
Diff against target: 34 lines (+9/-2)
3 files modified
debian/changelog (+7/-0)
debian/glance.glance-api.upstart (+1/-1)
debian/glance.glance-registry.upstart (+1/-1)
To merge this branch: bzr merge lp:~gandelman-a/ubuntu/oneiric/glance/lp784837
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+66400@code.launchpad.net

Description of the change

Removed shell output redirects in upstart jobs to ensure glance services have correct permissions to write to the default log files. Its probably a bad idea to have log files hard-coded here, anyway. Should close bug #784837.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

This looks fine, thanks!

review: Approve
Revision history for this message
Martin Pitt (pitti) wrote :

Hmm, seems someone already merged and uploaded this without updating the branch or bug.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-06-24 14:05:52 +0000
3+++ debian/changelog 2011-06-29 22:51:45 +0000
4@@ -1,3 +1,10 @@
5+glance (2011.3~d2~20110621.141-0ubuntu2) UNRELEASED; urgency=low
6+
7+ * Remove shell redirects in upstart jobs to ensure correct permissions
8+ on logfiles. (LP: #784837)
9+
10+ -- Adam Gandelman <adamg@canonical.com> Wed, 29 Jun 2011 11:18:14 -0700
11+
12 glance (2011.3~d2~20110621.141-0ubuntu1) oneiric; urgency=low
13
14 * New upstream release.
15
16=== modified file 'debian/glance.glance-api.upstart'
17--- debian/glance.glance-api.upstart 2011-05-25 15:57:15 +0000
18+++ debian/glance.glance-api.upstart 2011-06-29 22:51:45 +0000
19@@ -6,4 +6,4 @@
20
21 respawn
22
23-exec su -c "glance-api" glance >> /var/log/glance/api.log 2>&1
24+exec su -c "glance-api" glance
25
26=== modified file 'debian/glance.glance-registry.upstart'
27--- debian/glance.glance-registry.upstart 2011-05-25 15:57:15 +0000
28+++ debian/glance.glance-registry.upstart 2011-06-29 22:51:45 +0000
29@@ -6,4 +6,4 @@
30
31 respawn
32
33-exec su -c "glance-registry" glance >> /var/log/glance/registry.log 2>&1
34+exec su -c "glance-registry" glance

Subscribers

People subscribed via source and target branches